On Sep 6, 2017 13:13, "Rob Tompkins" <chtom...@gmail.com> wrote:
> On Sep 6, 2017, at 1:44 PM, Oliver Heger <oliver.he...@oliver-heger.de> wrote: > > Hello Rob, > > thank you for preparing another RC. > > I still have a 1.5 JDK and ant installed and was able to build the > source distribution successfully (on Windows 10). I have the impression > that the 'test' target does not actually execute tests, but this is > probably not a problem. > > I noticed the following things: > * The distributions do not have a root directory under which they > deflate; all content is on top level. Other components use specific root > folders for src and bin. > * The source distribution contains a README-binary-dist.txt file, but > this file is not contained in the binary distribution (where it probably > belongs). The file is outdated anyway, it still references > jakarta.apache.org. > * The README.txt in the source distribution is probably outdated, too. > It talks about Maven 1 as build tool and uses an old Apache header. > * The NOTICE file does not contain a copyright date. > * Artifacts have very limited manifests, for instance no OSGi meta > information is present. > * The pom.xml does not work, it produces a JAR with only a manifest. > > I think, most of these points are not blocking. For just getting out a > bugfix release, it is not necessary to fix them. About the NOTICE file I > am not sure, however. I assume that a valid copyright date is required. If that is indeed the case then I'll go for an RC5 with the above changes. Anyone else here thoughts before I give another try? Do pardon my repeated attempts here, sorting out this older component is more challenging than the standard component release mechanics. It's all good. I went up to RC7 on a Codec release once... Gary Thanks for the eyes, -Rob > > Oliver > >> Am 06.09.2017 um 13:44 schrieb Rob Tompkins: >> Hello, >> >> Commons Jelly 1.0.1 RC4 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision 21487) >> >> The tag is here (tag commit 1807466): >> https://svn.apache.org/repos/asf/commons/proper/jelly/tags/ commons-jelly-1.0.1-RC4 >> >> Commit the tag points at: >> 1807463 >> >> Maven Artifacts: >> https://repository.apache.org/content/repositories/orgapachecommons-1262 >> >> These are the Maven artifacts and their hashes: >> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-javadoc.jar> >> (SHA1: 40030f76f83f0150fce9e6e5df1e3b7e0498538e) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-sources.jar.asc> >> (SHA1: 6181719280762509243dba779437e2b998690181) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1.pom.asc> >> (SHA1: 0e67c74835c6f668d9c9ea6a91484f7d27510be8) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1.pom> >> (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1.jar.asc> >> (SHA1: ea9a7b0c06996515505427147f0e62a487394d06) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-javadoc.jar.asc> >> (SHA1: 3dc6dfec6dc755de6500822baa337b742f1402cc) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-sources.jar> >> (SHA1: 67fb8d04b8cb2357f3789d5623b54cabe4f302d1) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1.jar> >> (SHA1: 40645d9c20af4d072d570d49f6087acb8427d9a3) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-tests.jar.asc> >> (SHA1: c9a2f4c4fd0c03ad85adaf4d68fef1f206f64e33) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1- test-sources.jar.asc >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-test-sources.jar.asc> >> (SHA1: a5e450a33091dcdf080e359aeeb958aeede743cb) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-test-sources.jar> >> (SHA1: c4a6e671797be00657016bb39eb5fbe2860066ac) >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar >> <https://repository.apache.org/content/repositories/ orgapachecommons-1262/commons-jelly/commons-jelly/1.0.1/ commons-jelly-1.0.1-tests.jar> >> (SHA1: 687032952d79c56bc666ef01d95fb294a4c7c383) >> >> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0. Notes on building can be found in the >> BUILDING.md, included in the source distributions. And, the only changes between release candidates are documentation and build script changes. >> >> Details of changes since 1.0 are in the release notes: >> https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt >> >> Site: >> I have no site as this was generated with ant. My plan was to simply make minimal >> changes to the existant site for the purpose of documenting the patch. >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now, >> i.e. sometime after 12:00 (UTC) 9-September 2017 >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thanks! >> Rob >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
