The question is whether this breaks binary compatibility. If it does, this needs fixing. Unless there are other important changes that warrant a major version, I would go the sub-interface route; ugly, but workable within the same major release.
Gary On Mon, Aug 28, 2017 at 12:58 PM, Benedikt Ritter <brit...@apache.org> wrote: > Hi, > > Rev. 1782852 [1] has introduced two breaking changes by adding the methods: > > public void visitAnnotation(org.apache.bcel.classfile.Annotations) > public void visitAnnotationDefault(org.apache.bcel.classfile. > AnnotationDefault) > > to the interface org.apache.bcel.classfile.Visitor. The commit comment > indicates that these changes are needed by the Tomcat project. How do we > want to deal with this for the upcoming 6.1 release? I see several options: > > - accept these changes and make it explicit in release notes > - add a new interface which extends from the Visitor interface and add the > new methods to that interface > - major version bump (probably not the best idea…) > > Thoughts? > Benedikt > > [1] http://svn.apache.org/viewvc?view=revision&revision=1782852 < > http://svn.apache.org/viewvc?view=revision&revision=1782852>
