Let's not get side-tracked here, this is a [VOTE] thread ;-) Gary
On Mon, Jul 17, 2017 at 8:46 AM, Matt Sicker <boa...@gmail.com> wrote: > I've migrated Mockito code before, and the migration is pretty simple > depending on how complex your usage is. It could be as simple as changing > an import or two. > > On 17 July 2017 at 10:11, Carl Hall <carl.h...@gmail.com> wrote: > > > Thanks for pointing those out, sebb. I'll be sure to get all of those > > committed to master. Hopefully the Mockito jump isn't too much work. :) > > > > On Mon, Jul 17, 2017 at 1:48 AM, sebb <seb...@gmail.com> wrote: > > > > > Note: it's worth running the following: > > > > > > mvn versions:display-dependency-updates -U > > > and > > > mvn versions:display-plugin-updates -U > > > > > > to check for possible version updates > > > > > > These give: > > > > > > [INFO] The following dependencies in Dependencies have newer versions: > > > [INFO] junit:junit ............................................. > 4.11 > > > -> 4.12 > > > [INFO] org.mockito:mockito-core ............................. 1.9.5 > -> > > > 2.8.47 > > > > > > and > > > > > > [INFO] The following plugin updates are available: > > > [INFO] maven-changes-plugin ................................. 2.12 > -> > > > 2.12.1 > > > [INFO] > > > [WARNING] The following plugins do not have their version specified: > > > [WARNING] maven-checkstyle-plugin .............................. > > ....... > > > 2.17 > > > [WARNING] maven-pmd-plugin .............................. > > ............... > > > 3.8 > > > [WARNING] org.codehaus.mojo:findbugs-maven-plugin > .................... > > > 3.0.4 > > > > > > The mockito version is a big change and will need checking to ensure > > > it's compatible. > > > > > > > > > On 17 July 2017 at 03:08, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > I noticed it during > > > > > > > > mvn clean verify site > > > > > > > > Gary > > > > > > > > On Jul 16, 2017 18:34, "Carl Hall" <carl.h...@gmail.com> wrote: > > > > > > > >> Great feedback! Thanks so much. > > > >> > > > >> Would you please let me know how you're running PMD? I've tried > `mvn > > > >> pmd:pmd`. I'm not seeing issues locally and would like to make sure > > the > > > >> build is bulletproof. > > > >> > > > >> > > > >> On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory < > garydgreg...@gmail.com > > > > > > >> wrote: > > > >> > > > >> > +1 > > > >> > > > > >> > From src zip: ASC, MD5, and SHA1 OK. > > > >> > > > > >> > RAT and CLIRR check OK. > > > >> > > > > >> > Reports look OK. > > > >> > > > > >> > Issues to address but not blockers: > > > >> > - PMD blows up during the build and there is no resulting PMD > > report. > > > >> > - The POM uses an old version of commons-parent. > > > >> > > > > >> > Gary > > > >> > > > > >> > > > > >> > On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall <carl.h...@gmail.com> > > > wrote: > > > >> > > > > >> > > Hi, > > > >> > > > > > >> > > It's been almost 3 years to the day since we've had a DbUtils > > > release. > > > >> > > We've fixed several important bugs and added some new features, > > so I > > > >> > would > > > >> > > like to release DbUtils 1.7. > > > >> > > > > > >> > > Furthermore, we have fixed these issues for RC2, which were > > > discovered > > > >> in > > > >> > > RC1: > > > >> > > - resource leaks as found by FindBugs > > > >> > > - updated links & text in generated texts and site > > > >> > > > > > >> > > DbUtils 1.7 RC2 is available for review here: > > > >> > > https://dist.apache.org/repos/dist/dev/commons/dbutils/ > > > >> > DBUTILS_1_7_RC2/ > > > >> > > (svn > > > >> > > revision 20455) > > > >> > > > > > >> > > The tag is here: > > > >> > > *https://git-wip-us.apache.org/repos/asf?p=commons- > > > >> > dbutils.git;a=tag;h= > > > >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a > > > >> > > <https://git-wip-us.apache.org/repos/asf?p=commons- > > > >> dbutils.git;a=tag;h= > > > >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a>* > > > >> > > > > > >> > > Maven artifacts are here: > > > >> > > https://repository.apache.org/content/repositories/ > > > >> > > orgapachecommons-1254 > > > >> > > > > > >> > > These are the Maven Artifacts and their hashes: > > > >> > > > > > >> > > commons-dbutils-1.7-javadoc.jar > > > >> > > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d) > > > >> > > commons-dbutils-1.7-javadoc.jar.asc > > > >> > > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0) > > > >> > > commons-dbutils-1.7-javadoc.jar.md5 > > > >> > > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176) > > > >> > > commons-dbutils-1.7-javadoc.jar.sha1 > > > >> > > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14) > > > >> > > commons-dbutils-1.7-sources.jar > > > >> > > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b) > > > >> > > commons-dbutils-1.7-sources.jar.asc > > > >> > > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09) > > > >> > > commons-dbutils-1.7-sources.jar.md5 > > > >> > > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25) > > > >> > > commons-dbutils-1.7-sources.jar.sha1 > > > >> > > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32) > > > >> > > commons-dbutils-1.7-test-sources.jar > > > >> > > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0) > > > >> > > commons-dbutils-1.7-test-sources.jar.asc > > > >> > > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f) > > > >> > > commons-dbutils-1.7-test-sources.jar.md5 > > > >> > > (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7) > > > >> > > commons-dbutils-1.7-test-sources.jar.sha1 > > > >> > > (SHA: 38d6480819b9d813ad18307349a19603ed53f453) > > > >> > > commons-dbutils-1.7-tests.jar > > > >> > > (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3) > > > >> > > commons-dbutils-1.7-tests.jar.asc > > > >> > > (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc) > > > >> > > commons-dbutils-1.7-tests.jar.md5 > > > >> > > (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e) > > > >> > > commons-dbutils-1.7-tests.jar.sha1 > > > >> > > (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf) > > > >> > > commons-dbutils-1.7.jar > > > >> > > (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370) > > > >> > > commons-dbutils-1.7.jar.asc > > > >> > > (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c) > > > >> > > commons-dbutils-1.7.jar.md5 > > > >> > > (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5) > > > >> > > commons-dbutils-1.7.jar.sha1 > > > >> > > (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8) > > > >> > > commons-dbutils-1.7.pom > > > >> > > (SHA: dcaebe462df8501f14d764f2bece496e942586eb) > > > >> > > commons-dbutils-1.7.pom.asc > > > >> > > (SHA: 0547d14d07117cc496c018ef7fd320ae32884287) > > > >> > > commons-dbutils-1.7.pom.md5 > > > >> > > (SHA: c5a32289a952a40202461528eeffcad474d0ef6c) > > > >> > > commons-dbutils-1.7.pom.sha1 > > > >> > > (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398) > > > >> > > > > > >> > > Details of changes since 1.6 are in the release notes: > > > >> > > > > > >> > > https://dist.apache.org/repos/dist/dev/commons/dbutils/ > > > >> > > DBUTILS_1_7_RC2/RELEASE-NOTES.txt > > > >> > > https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/ > > > >> > > changes-report.html > > > >> > > > > > >> > > Site: > > > >> > > https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/ > > > >> > > > > > >> > > Clirr Report (compared to 1.6): > > > >> > > https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/ > > > >> > clirr-report.html > > > >> > > > > > >> > > - All changes are additions and do not represent any > > fundamental > > > or > > > >> > > breaking changes in how to use the library, so not revving the > > > version. > > > >> > > > > > >> > > RAT Report: > > > >> > > https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/ > > > >> rat-report.html > > > >> > > > > > >> > > KEYS: > > > >> > > https://www.apache.org/dist/commons/KEYS > > > >> > > > > > >> > > Please review the release candidate and vote. > > > >> > > This vote will close no sooner that 72 hours from now, > > > >> > > i.e. sometime after 23:00 UTC 19-July-2017 > > > >> > > > > > >> > > [ ] +1 Release these artifacts > > > >> > > [ ] +0 OK, but... > > > >> > > [ ] -0 OK, but really should fix... > > > >> > > [ ] -1 I oppose this release because... > > > >> > > > > > >> > > Thanks! > > > >> > > -Carl > > > >> > > > > > >> > > > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > -- > Matt Sicker <boa...@gmail.com> >
