On Wed, May 17, 2017 at 1:41 PM, Benedikt Ritter <brit...@apache.org> wrote:
> Hello Gary, > > > Am 17.05.2017 um 14:44 schrieb Gary Gregory <garydgreg...@gmail.com>: > > > > I hate to be the bearer of bad news but the src zip does not build 'mvn > > site' because it is missing a checkstyle file: > > > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] BUILD FAILURE > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 02:23 min > > [INFO] Finished at: 2017-05-17T11:41:32-07:00 > > [INFO] Final Memory: 80M/895M > > [INFO] > > ------------------------------------------------------------------------ > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on > > project commons-lang3: Error generating > > maven-checkstyle-plugin:2.17:checkstyle: Failed during checkstyle > > execution: *Unable to find suppressions file at location: > > C:\temp\rc\commons-lang3-3.6-src/checkstyle-suppressions.xml*: Could not > > find resource > > 'C:\temp\rc\commons-lang3-3.6-src/checkstyle-suppressions.xml'. -> > [Help 1] > > [ERROR] > > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e > > switch. > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > > please read the following articles: > > [ERROR] [Help 1] > > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > <http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException> > > > > Gary > > If you think a failing site build is blocking the release you’re free to > vote -1 (which I’d like to ask you to do explicitly). > I don’t think that a failing site build should block a release (although > we should fix this for 3.6.1). So if the majority of the voters is okay > with this, I think I’m going to release the code anyway. > Hi Benedikt, Strictly speaking this should not block the release BUT... the way I got started here, is by making small fixes and additions and THEN running a full build with reports to make sure I did not make things worse. So to me, being able to build a full site is the best way to validate changes. This is what makes the component approachable to new contributors. If we deliver a broken build, this creates an impedance for contributors, again, IMO. So for now, I'll abstain but will not -1 the RC. Gary > > Cheers, > Benedikt > > > > > On Wed, May 17, 2017 at 9:02 AM, Benedikt Ritter <brit...@apache.org > <mailto:brit...@apache.org>> wrote: > > > >> Hello, > >> > >> we have fixed quite a few bugs and added some nice new features since > >> Commons Lang 3.5 was released, so I would like to release Commons Lang > 3.6 > >> based on RC2. > >> The reason we had to cut a second release is, that there were some > >> discussions around the annotations for documenting concurrency > properties > >> in the o.a.c.l.concurrent.annotation package. I’ve removed those > >> annotations, so that we can fix them after the release. > >> > >> Commons Lang 3.6 R2 is available for review here: > >> https://dist.apache.org/repos/dist/dev/commons/lang (svn revision > 19714) > >> > >> The tag is here: > >> https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=tag;h= > >> 75c28fc4678774c1d2c21b839b048db6b563b9ae > >> > >> Commit ID the tag points at: > >> 3a64cf6aff408a9cbdcb4d7456360a97d1a880f0 > >> > >> Maven Artifacts: > >> https://repository.apache.org/content/repositories/ > orgapachecommons-1247 > >> > >> These are the Maven artifacts and their hashes: > >> > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-javadoc.jar < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-javadoc.jar> > >> (SHA1: eb05c235b85ffb6f70ea72082eb904a9fe1969d7) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-sources.jar.asc > < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-sources.jar.asc> > >> (SHA1: 7b98c8ab56e16e974c85963b2497840405a3375e) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.pom.asc < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6.pom.asc> > >> (SHA1: 7524211600afb0deb3a5cab8ad9236299e3434a4) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.pom < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6.pom> > >> (SHA1: b38df078df7623b708cd439b1cb750619bd659cc) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar.asc < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6.jar.asc> > >> (SHA1: 4bf4d61116adcf699f1d7a866bcabcb50fc7b47f) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-javadoc.jar.asc > < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-javadoc.jar.asc> > >> (SHA1: d547ce41d41f38b143f5e5377d6bc990f0abbff6) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-sources.jar < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-sources.jar> > >> (SHA1: d9c5bbfb0b97c1f87e3f75cedd7eedbc5ec81182) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6.jar> > >> (SHA1: e6e1ca5e4574da2af0f8d2891410857e36ce5969) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-tests.jar.asc < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-tests.jar.asc> > >> (SHA1: b8d25f4a01a5f50ab450044dd2a7688e37554bed) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6- > test-sources.jar.asc > >> <https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-test-sources.jar.asc> > >> (SHA1: ccca81cd4539437f3def2644119a6f187168963c) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-test-sources.jar > < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-test-sources.jar> > >> (SHA1: 8daf4979fb38811bd4a5bf39e38bc7a3a6582104) > >> /org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-tests.jar < > >> https://repository.apache.org/content/repositories/ < > https://repository.apache.org/content/repositories/> > >> orgapachecommons-1247/org/apache/commons/commons-lang3/ > >> 3.6/commons-lang3-3.6-tests.jar> > >> (SHA1: 1f158e950250efab7cbca635e8393ab2ef666bca) > >> > >> I have tested this with JDK 7, JDK 8 and JDK 9 EA b165 using Maven > 3.5.0. > >> > >> Details of changes since 3.5 are in the release notes: > >> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE- > NOTES.txt > >> http://home.apache.org/~britter/commons/lang/LANG_3_6_ > >> RC2/changes-report.html > >> > >> Site: > >> http://home.apache.org/~britter/commons/lang/LANG_3_6_RC2/ > >> (note some *relative* links are broken and the 3.6 directories are > >> not yet created - these will be OK once the site is deployed) > >> > >> Clirr Report (compared to 3.5): > >> http://home.apache.org/~britter/commons/lang/LANG_3_6_ > >> RC2/clirr-report.html > >> > >> RAT Report: > >> http://home.apache.org/~britter/commons/lang/LANG_3_6_ > >> RC2/rat-report.html > >> > >> KEYS: > >> https://www.apache.org/dist/commons/KEYS > >> > >> Please review the release candidate and vote. > >> This vote will close no sooner that 72 hours from now, > >> i.e. sometime after 12:00 EDT (UTC-4) 20-May 2017 > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > >> > >> Thanks! > >> Benedikt > > > > > > > > > > -- > > E-Mail: garydgreg...@gmail.com <mailto:garydgreg...@gmail.com> | > ggreg...@apache.org <mailto:ggreg...@apache.org> > > Java Persistence with Hibernate, Second Edition > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459& > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8 < > https://www.amazon.com/gp/product/1617290459/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459& > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1617290459 <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l= > am2&o=1&a=1617290459>> > > JUnit in Action, Second Edition > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021& > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22 > <https://www.amazon.com/gp/product/1935182021/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021& > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22 > >> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1935182021 <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l= > am2&o=1&a=1935182021>> > > Spring Batch in Action > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951& > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B% > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action <https://www.amazon.com/gp/ > product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative= > 9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D& > tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action > >> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1935182951 <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l= > am2&o=1&a=1935182951>> > > Blog: http://garygregory.wordpress.com <http://garygregory.wordpress. > com/> > > Home: http://garygregory.com/ <http://garygregory.com/> > > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory> > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory