On 4 May 2017 at 23:02, Gilles <gil...@harfang.homelinux.org> wrote: > On Thu, 4 May 2017 11:02:59 +0100, sebb wrote: >> >> On 4 May 2017 at 09:57, Gilles <gil...@harfang.homelinux.org> wrote: >>> >>> On Thu, 4 May 2017 09:19:49 +0100, sebb wrote: >>>> >>>> >>>> On 4 May 2017 at 00:48, Gilles <gil...@harfang.homelinux.org> wrote: >>>>> >>>>> >>>>> Same commit, different behaviour... >>>> >>>> >>>> >>>> Travis and Jenkins check different things... >>>> >>>>> https://travis-ci.org/apache/commons-math/ >>>>> >>>>> >>>>> https://builds.apache.org/job/Commons%20Math%20MasterBranch/34/console >>>> >>>> >>>> >>>> Exit code: 1 - javadoc: error - invalid flag: >>>> --allow-script-in-comments >>> >>> >>> >>> I knew that it was caused by my adding this flag in the POM file. >>> Without this flag, the build fails with Java 8; with the flag, it >>> fails with Java 7. >> >> >> If the flag is really necessary for Java 8 (i.e. the Javadoc cannot >> readily be adjusted to avoid the problem) then obviously the flag >> setting will need to depend on the Java version being used to compile >> the code. >> >> The Commons Parent pom has some examples of settings that are >> conditional upon the Java version. > > > Finally, I configured Jenkins so that the job will skip the javadoc > generation. Good enough until Jenkins will *require* Java 8.
I disagree. It's now not possible to generate the Javadoc using Java7, i.e. the following fails: mvn javadoc:javadoc Given that the code targets Java 7, that does not make sense to me. This is actually nothing to do with Jenkins (or Travis AFAICT). This seems purely to be a problem cause by a stricter Java8 Javadoc processor. I think it needs to be resolved as such, not by suppressing the CI build errors that exhibit the problem. In any case, it looks like the Javadoc is not compatible with Java 8 for other reasons. As it stands, dropping the '--allow-script-in-comments' qualifier allows Javadoc7 to work with a couple of warnings. There's quite a lot of source fixes needed to make the Javadoc8 processor happy even without MathJax. (missing tags, malformed HTML etc). > Regards, > Gilles > > >> >>> >>>> >>>>> Regards, >>>>> Gilles >>>>> >>>>> >>> >>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
