On 2017-05-03, Gary Gregory wrote: > On May 2, 2017 9:19 PM, "Stefan Bodewig" <bode...@apache.org> wrote:
>> On 2017-05-02, <ggreg...@apache.org> wrote: >>> @@ -245,6 +251,7 @@ jar, tar, zip, dump, 7z, arj. >>> <configuration> >>> <instructions> >>> >>> <Import-Package>org.tukaani.xz;resolution:=optional</Import-Package> >>> + >>> <Import-Package>org.brotli.dec;resolution:=optional</Import-Package> >>> </instructions> >>> </configuration> >>> </plugin> >> org.brotli:dec is not an OSGi bundle as far as I can tell. Is this going >> to work or will it break Compress in an OSGi environment? Looking at what we did back with https://issues.apache.org/jira/browse/COMPRESS-199 (Jukka's proposed patch) this may actually be enough. > Good question... I do not see use of the bundle plugin in > https://github.com/google/brotli/blob/master/java/org/brotli/dec/pom.xml > Assuming I am looking in right place... > Maybe a PR would help ;-) Yeah, I did that for XZ for Java at that time. dec probably doesn't really use Maven to build even though there is a POM. I suspect it is using Bazel (see the BUILD file inside the source directory), I'd need to figure out how to add a manifest to a Bazel built jar first. Might move "take a closer look at Bazel" further up on my TODO list. :-) Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
