> On Jan 27, 2017, at 12:51 PM, Rob Tompkins <chtom...@gmail.com> wrote: > > > >> On Jan 27, 2017, at 12:11 PM, Oliver Heger <oliver.he...@oliver-heger.de> >> wrote: >> >> Hi, >> >> build works with Java 1.7 and 1.8 on Windows 10. The site build failed >> for me with Java 1.8 with the following error: >> >> [ERROR] Failed to execute goal >> org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on >> project commons-text: Error generating >> maven-checkstyle-plugin:2.13:checkstyle: Failed during checkstyle >> execution: Unable to find suppressions file at location: >> C:\data\dev\projects\OpenSource\text\commons-text-1.0-beta-1-src/checkstyle-suppressions.xml: >> Could not find resource >> 'C:\data\dev\projects\OpenSource\text\commons-text-1.0-beta-1-src/checkstyle-suppressions.xml'. >> >> >> I guess, the referenced file is missing from the distribution. >> >> Artifacts and site look good, it would be helpful to have some user's >> guide - currently only Javadocs are available. Would it be possible to >> copy something from [lang]? (This can be added later.) >> >> For the release notes it seems a bit strange that the initial release >> contains bugfixes and removed classes. This may be okay because of the >> history of [text]. Maybe, the release notes should state where most of >> the classes come from and thus give a justification for the listed >> changes. There is a typo in the bottom: "-Apachje Commons Text team". >> >> There are some Checkstyle and Findbugs errors which may be worth looking >> after, but probably nothing critical. >> >> Mainly because of the problems with the site build I am -0. >> > > Thanks for the notes here. Sounds like there's enough here for a rebuild. I'm > curious if anyone else has had a look at things, and if so if there are any > issues other than those brought up here by Oliver. >
I’m going to work on implementing Oliver’s suggestions here. Oliver - thanks again. Feels like I did ok(ish) for a first go at a release candidate. :-) Cheers, -Rob > -Rob > >> Oliver >> >>> Am 26.01.2017 um 12:29 schrieb Rob Tompkins: >>> Hello all, >>> >>> This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC2). >>> >>> Tag name: >>> commons-text-1.0-beta-1-RC2 (signature can be checked from git using 'git >>> tag -v') >>> >>> Tag URL: >>> >>> https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commit;h=61eb9d01d3be74f692f9f9be5a988bdcbc09f6ec >>> >>> <https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commit;h=61eb9d01d3be74f692f9f9be5a988bdcbc09f6ec> >>> >>> Commit ID the tag points at: >>> 61eb9d01d3be74f692f9f9be5a988bdcbc09f6ec >>> >>> Site: >>> http://home.apache.org/~chtompki/commons-text-1.0-beta-1-RC2 >>> <http://home.apache.org/~chtompki/commons-text-1.0-beta-1-RC2> >>> >>> Distribution files (committed at revision 17998): >>> https://dist.apache.org/repos/dist/dev/commons/text/ >>> <https://dist.apache.org/repos/dist/dev/commons/text/> >>> >>> Distribution files hashes (SHA1): >>> commons-text-1.0-beta-1-bin.tar.gz >>> (SHA: b6aed4897e831960f916942e06183dfb6403c353) >>> commons-text-1.0-beta-1-bin.zip >>> (SHA1: 620a43c8c8dfc7b3a3cc2a5bca74bdd34a04b427) >>> commons-text-1.0-beta-1-src.tar.gz >>> (SHA1: bff10c7b2d60a19eb59f6901bb9c3a7b15ec5dec) >>> commons-text-1.0-beta-1-src.zip >>> (SHA1: 67d31b46394e0de29d7c15940c622ff0eada1880) >>> >>> These are the Maven artifacts and their hashes: >>> commons-text-1.0-beta-1-javadoc.jar >>> (SHA1: 7c6e55802e4212426420dd4a0c67d45a21ccb7be) >>> commons-text-1.0-beta-1-sources.jar >>> (SHA1: 2524aa9bf1abf8e66f06eec020f322d145822f67) >>> commons-text-1.0-beta-1-test-sources.jar >>> (SHA1: c70ec496b9a77cf1eb03c029a738878794d66f4a) >>> commons-text-1.0-beta-1-tests.jar >>> (SHA1: 31575513a2dd455449008448d8ad38251c44269f) >>> commons-text-1.0-beta-1.jar >>> (SHA1: fd7717aabcbccef124f5f694c009f7f76e028cd2) >>> commons-text-1.0-beta-1.pom >>> (SHA1: 3998e133a3912580053a71cb9dd55d618bf9d129) >>> >>> KEYS file to check signatures: >>> http://www.apache.org/dist/commons/KEYS >>> <http://www.apache.org/dist/commons/KEYS> >>> >>> Maven artifacts: >>> https://repository.apache.org/content/repositories/orgapachecommons-1233 >>> <https://repository.apache.org/content/repositories/orgapachecommons-1233> >>> >>> Please select one of the following options[1]: >>> [ ] +1 Release it. >>> [ ] +0 Go ahead; I don't care. >>> [ ] -0 There are a few minor glitches: ... >>> [ ] -1 No, do not release it because ... >>> >>> This vote will be open at least 72 hours, i.e. until >>> 2017-01-29T12:00:00Z >>> (this is UTC time). >>> -------- >>> >>> Cheers, >>> -Rob >>> >>> [1] http://apache.org/foundation/voting.html >>> <http://apache.org/foundation/voting.html> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
