> On Jan 24, 2017, at 3:56 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > I'm not a fan of shading within commons. > > In most projects I work on, I end up depending on a ton of stuff and it > seems silly to create duplication within Commons itself. > > Am I ever going to write a program that depends solely on [text]? I doubt > it. And if I did and it depended on [lang3] transitively, that would be > fine. >
Seems reasonable. I was just sticking to the previous pattern. I'll pull the shade out so long as no one else has any substantive concerns. -Rob > 2c, > > Gary > > > ---------- Forwarded message ---------- > From: <chtom...@apache.org> > Date: Tue, Jan 24, 2017 at 5:08 AM > Subject: [text] shade plugin into beta package > To: comm...@commons.apache.org > > > Repository: commons-text > Updated Branches: > refs/heads/master 74bf2cf7d -> 736326bff > > > shade plugin into beta package > > > Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo > Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/736326bf > Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/736326bf > Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/736326bf > > Branch: refs/heads/master > Commit: 736326bffc40c36c29e8bd718739eec4948cb814 > Parents: 74bf2cf > Author: Rob Tompkins <chtom...@gmail.com> > Authored: Tue Jan 24 08:08:13 2017 -0500 > Committer: Rob Tompkins <chtom...@gmail.com> > Committed: Tue Jan 24 08:08:13 2017 -0500 > > ---------------------------------------------------------------------- > pom.xml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/commons-text/blob/736326bf/pom.xml > ---------------------------------------------------------------------- > diff --git a/pom.xml b/pom.xml > index 6ecf272..1e1b703 100644 > --- a/pom.xml > +++ b/pom.xml > @@ -205,23 +205,23 @@ > <relocations> > <relocation> > <pattern>org.apache.commons.lang3.builder.</pattern> > - <shadedPattern>org.apache.commons.text._lang3.builder.__ > </shadedPattern> > + <shadedPattern>org.apache.commons.text.beta._lang3. > builder.__</shadedPattern> > </relocation> > <relocation> > <pattern>org.apache.commons.lang3.exception.</pattern> > - <shadedPattern>org.apache.commons.text._lang3.exception. > __</shadedPattern> > + <shadedPattern>org.apache.commons.text.beta._lang3. > exception.__</shadedPattern> > </relocation> > <relocation> > <pattern>org.apache.commons.lang3.mutable.</pattern> > - <shadedPattern>org.apache.commons.text._lang3.mutable.__ > </shadedPattern> > + <shadedPattern>org.apache.commons.text.beta._lang3. > mutable.__</shadedPattern> > </relocation> > <relocation> > <pattern>org.apache.commons.lang3.tuple.</pattern> > - <shadedPattern>org.apache.commons.text._lang3.tuple.__</ > shadedPattern> > + <shadedPattern>org.apache.commons.text.beta._lang3. > tuple.__</shadedPattern> > </relocation> > <relocation> > <pattern>org.apache.commons.lang3.</pattern> > - <shadedPattern>org.apache.commons.text._lang3.__</ > shadedPattern> > + <shadedPattern>org.apache.commons.text.beta._lang3.__</ > shadedPattern> > </relocation> > </relocations> > </configuration> > > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> > JUnit in Action, Second Edition > <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> > Spring Batch in Action > <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
