Vote: -1 mainly for license, but there’s the following as well.
I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and got the
following test failure (note that it seems to be intermittent):
testSampling[22:
data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb (inverse
method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0x11eab77f808cf641L, 32, 106120225] + Cmres: [0x0f1505c780688cb5L, 33,
192641895])]: deciles=[55.074313383177326, 143.04583109008863,
422.11049795027907, 1472.1250669034735, 6450.716651619402, 39349.60019433535,
404957.85425759235, 1.0824440136808794E7,
2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)
Time elapsed: 2.792 sec <<< FAILURE!
java.lang.AssertionError:
org.apache.commons.math3.distribution.ParetoDistribution@185c0deb (inverse
method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0x11eab77f808cf641L, 32, 106120225] + Cmres: [0x0f1505c780688cb5L, 33,
192641895])]: Too many failures for sample size = 20000 (3 out of 50 tests
failed, chi2=[24.237000000000002, 21.682000000000002, 23.912000000000003]
at
org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
at
org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)
Running
org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.134 sec - in
org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
Running org.apache.commons.rng.sampling.ListSamplerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 sec - in
org.apache.commons.rng.sampling.ListSamplerTest
Running org.apache.commons.rng.sampling.PermutationSamplerTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec - in
org.apache.commons.rng.sampling.PermutationSamplerTest
Results :
Failed tests:
ContinuousSamplerParametricTest.testSampling:53->check:127
org.apache.commons.math3.distribution.ParetoDistribution@185c0deb (inverse
method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0x11eab77f808cf641L, 32, 106120225] + Cmres: [0x0f1505c780688cb5L, 33,
192641895])]: Too many failures for sample size = 20000 (3 out of 50 tests
failed, chi2=[24.237000000000002, 21.682000000000002, 23.912000000000003]
> On Dec 1, 2016, at 6:18 AM, Artem Barger <[email protected]> wrote:
>
> My vote: +1
>
> Best regards,
> Artem Barger.
>
> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <[email protected]>
> wrote:
>
>> My vote: +1 (binding)
>>
>> Looking good!
>>
>>
>> Checked:
>>
>> +1 commit matches tag (even signed tag, yay!)
>> +0 commit matches src (git tag is missing
>> "<createChecksum>true</createChecksum>" -- why?)
>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
>> was not staged :-( )
>> +1 bin JARs matches staging repo hashes
>> +1 zip vs tar.gz
>> +1 .asc signatures of dist and repo
>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>> correctly the zip/tar.gz)
>> +0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
>> +1 no unexpected binaries
>> +1 mvn clean install
>> +1 .. and afterwards in commons-rng-examples
>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
>> separately in source)
>> +1 RELEASE-NOTES
>> +1 LICENSE, NOTICE
>> +1 site (minor markdown highlight bug "64 bits" at
>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>> +1 javadoc
>>
>> On 30 November 2016 at 00:08, Gilles <[email protected]> wrote:
>>> Hi.
>>>
>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>
>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>> * Modularization
>>> * Non-uniform deviates (in module "commons-rng-sampling")
>>>
>>>
>>> Tag name:
>>> RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>>
>>> Tag URL:
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>> f9de6401e981554c3f44936c2272429e290fdbec
>>>
>>> Commit ID the tag points at:
>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>
>>> Site:
>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>
>>> Distribution files:
>>> https://dist.apache.org/repos/dist/dev/commons/rng/
>>>
>>> Distribution files hashes (SHA1):
>>> de2a54518a0ef10ba5a2be1c3b060a441f4466e2 commons-rng-1.0-bin.tar.gz.
>> sha1
>>> cfcfde1f65dec9c30be1273ff2237d551eb87933 commons-rng-1.0-bin.zip.sha1
>>> 6d529de9418314066727a7d5ada88dd87dc0163d commons-rng-1.0-src.tar.gz.
>> sha1
>>> 561dd3e5ebf53d60e883d5c04e543f58374c45b6 commons-rng-1.0-src.zip.sha1
>>>
>>> KEYS file to check signatures:
>>> http://www.apache.org/dist/commons/KEYS
>>>
>>> Maven artifacts:
>>> https://repository.apache.org/content/repositories/
>> orgapachecommons-1225/
>>>
>>>
>>> [ ] +1 Release it.
>>> [ ] +0 Go ahead; I don't care.
>>> [ ] -0 There are a few minor glitches: ...
>>> [ ] -1 No, do not release it because ...
>>>
>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
>>> time).
>>> ----------
>>>
>>>
>>> Thanks,
>>> Gilles
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>>
>>
>>
>>
>> --
>> Stian Soiland-Reyes
>> http://orcid.org/0000-0001-9842-9718
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
