I updated this test to use try with resources, which is also one less warning per instance of the allocate/close pattern.
Gary On Mon, Sep 5, 2016 at 1:49 PM, <s...@apache.org> wrote: > Repository: commons-compress > Updated Branches: > refs/heads/master 52dd5908e -> 159d9c646 > > > Avoid unclosed stream warnings > > Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo > Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/ > commit/159d9c64 > Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/ > tree/159d9c64 > Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/ > diff/159d9c64 > > Branch: refs/heads/master > Commit: 159d9c646d598edde1dbf2e20bb3879abaea7694 > Parents: 52dd590 > Author: Sebb <s...@apache.org> > Authored: Mon Sep 5 18:48:57 2016 +0100 > Committer: Sebb <s...@apache.org> > Committed: Mon Sep 5 18:48:57 2016 +0100 > > ---------------------------------------------------------------------- > .../java/org/apache/commons/compress/utils/BitInputStreamTest.java | 2 ++ > 1 file changed, 2 insertions(+) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/commons-compress/ > blob/159d9c64/src/test/java/org/apache/commons/compress/ > utils/BitInputStreamTest.java > ---------------------------------------------------------------------- > diff --git > a/src/test/java/org/apache/commons/compress/utils/BitInputStreamTest.java > b/src/test/java/org/apache/commons/compress/utils/BitInputStreamTest.java > index 11ff956..c9cfbd2 100644 > --- a/src/test/java/org/apache/commons/compress/utils/ > BitInputStreamTest.java > +++ b/src/test/java/org/apache/commons/compress/utils/ > BitInputStreamTest.java > @@ -143,6 +143,7 @@ public class BitInputStreamTest { > assertEquals(1186, // 01001010-0010 > bin.readBits(12)); > assertEquals(-1 , bin.readBits(1)); > + bin.close(); > } > > @Test > @@ -167,6 +168,7 @@ public class BitInputStreamTest { > assertEquals(330, // 0001-01001010 > bin.readBits(12)); > assertEquals(-1 , bin.readBits(1)); > + bin.close(); > } > > private ByteArrayInputStream getStream() { > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory