> On Aug 22, 2016, at 11:09 AM, Gilles <gil...@harfang.homelinux.org> wrote: > > On Mon, 22 Aug 2016 10:47:43 -0400, Rob Tompkins wrote: >>> On Aug 22, 2016, at 9:19 AM, Gilles <gil...@harfang.homelinux.org> wrote: >>> >>>> On Mon, 22 Aug 2016 07:57:00 -0400, Rob Tompkins wrote: >>>> Hey Gilles, >>>> >>>> I switched the coveralls reporting portion of the travis build back >>>> from cobertura to jacoco and got it working: >>>> >>>> https://github.com/apache/commons-rng/pull/2 >>>> <https://github.com/apache/commons-rng/pull/2> >>> >>> There is something I don't get: This page >>> https://travis-ci.org/apache/commons-rng >>> refers to a commit of yours; but you did not commit anything yet (IIUC). >>> >>> Where did "Travis" get that information? >>> What is it tracking actually? >>> >>> I must miss something. >>> >> >> I think that it is building the potentially committed pull request >> here. So it checks out master and merges in the pull request without >> pushing back up to master, and builds that. > > Nice! > > Would it be possible to have Travis also run "checkstyle" (so that > committers won't even have to create a local branch if a patch is > to be improved due to formatting problem)?
Sure. That’s not a problem at all. Currently we have in the pom.xml, checkstyle’s “failOnViolation" set to false. I can add the validate maven target to the .travis.yml, but we might at least want minimally to switch “logViolationsToConsole” to true. Thoughts? -Rob > > Gilles > > >> It then posts the status >> back to the pull request. >> >> -Rob >> >>> [...] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > <mailto:dev-unsubscr...@commons.apache.org> > For additional commands, e-mail: dev-h...@commons.apache.org > <mailto:dev-h...@commons.apache.org>
