On Thu, 18 Aug 2016 00:51:23 +0300, Artem Barger wrote:
On Thu, Aug 18, 2016 at 12:48 AM, Gilles
<gil...@harfang.homelinux.org>
wrote:
The "test" part of the source code need not have the same level
of cleanliness as the "main" part.
It was not usually scanned by checkstyle, which now outputs
many spurious errors.
​Well, test code is also a code one need to support,
Fine; but we should strive to not commit checkstyle errors: You
are welcome to fix the test files. ;-)
but I'm fine to relax it
to the previous configuration, a matter of setting one property.
I surely agree that tests should be clean too, but check that
the rules are really useful.
Example where they are not:
* Trailing spaces in arrays (that were generated by a script)
* Javadoc for test methods (which are supposedly self-documenting)
I've addressed all your recent comments and pushed into separate
branch
"checkstyle". Will wait
for your confirmation before merging it into master.
Report looks fine, now.
Gilles
Best regards,
Artem Barger.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
