Hi Benedikt, Thank you for your review and suggestion, I think the commit is mainly fixing some typos and error links, I will also pay attention to the formatting.
Welcome back :) Regards Dapeng -----Original Message----- From: Benedikt Ritter [mailto:brit...@apache.org] Sent: Wednesday, August 17, 2016 2:33 PM To: dev@commons.apache.org Subject: Re: commons-crypto git commit: CRYPTO-122: Fix CRYPTO website after 1.0.0 Hello Dapeng, it looks like this commit contains a lot of unrelated formatting changes. Keeping change sets small an focused makes it easier for others to review the changes. Thank you! Benedikt <s...@apache.org> schrieb am Mi., 17. Aug. 2016 um 03:43 Uhr: > Repository: commons-crypto > Updated Branches: > refs/heads/master d94c71904 -> 3f6e54994 > > > CRYPTO-122: Fix CRYPTO website after 1.0.0 > > > Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo > Commit: > http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/3f6e5499 > Tree: > http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/3f6e5499 > Diff: > http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/3f6e5499 > > Branch: refs/heads/master > Commit: 3f6e549948fbb6584a21c2350e410cb834f28502 > Parents: d94c719 > Author: Sun Dapeng <s...@apache.org> > Authored: Wed Aug 17 09:37:08 2016 +0800 > Committer: Sun Dapeng <s...@apache.org> > Committed: Wed Aug 17 09:37:08 2016 +0800 > > ---------------------------------------------------------------------- > README.md | 4 ++-- > RELEASE-NOTES.txt | 4 ++-- > pom.xml | 4 ++-- > src/site/resources/download_crypto.cgi | 2 +- > src/site/site.xml | 2 +- > src/site/xdoc/index.xml | 10 +++++----- > 6 files changed, 13 insertions(+), 13 deletions(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/3f6e5499/RE > ADME.md > ---------------------------------------------------------------------- > diff --git a/README.md b/README.md > index 15b98ce..d037270 100644 > --- a/README.md > +++ b/README.md > @@ -58,9 +58,9 @@ Features > -------- > > 1. Cipher API for low level cryptographic operations. > -2. Java stream API (CryptoInputStream/CryptoOutputStream) for high > level stream encyrption/decryption. > +2. Java stream API (CryptoInputStream/CryptoOutputStream) for high > +level > stream encryption/decryption. > 3. Both optimized with high performance AES encryption/decryption. > (1400 MB/s - 1700 MB/s throughput in modern Xeon processors). > -4. JNI-based implementation to achieve comparable performance to the > native C++ version based on OpenSsl. > +4. JNI-based implementation to achieve comparable performance to the > native C/C++ version based on OpenSsl. > 5. Portable across various operating systems (currently only > Linux/MacOSX/Windows); > Apache Commons Crypto loads the library according to your machine > environment (it checks system properties, `os.name` and `os.arch`). > 6. Simple usage. Add the commons-crypto-(version).jar file to your > classpath. > > > http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/3f6e5499/RE > LEASE-NOTES.txt > ---------------------------------------------------------------------- > diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index > f98d1c4..083898d 100644 > --- a/RELEASE-NOTES.txt > +++ b/RELEASE-NOTES.txt > @@ -13,9 +13,9 @@ Features > -------- > > 1. Cipher API for low level cryptographic operations. > -2. Java stream API (CryptoInputStream/CryptoOutputStream) for high > level stream encyrption/decryption. > +2. Java stream API (CryptoInputStream/CryptoOutputStream) for high > +level > stream encryption/decryption. > 3. Both optimized with high performance AES encryption/decryption. > (1400 MB/s - 1700 MB/s throughput in modern Xeon processors). > -4. JNI-based implementation to achieve comparable performance to the > native C++ version based on OpenSsl. > +4. JNI-based implementation to achieve comparable performance to the > native C/C++ version based on OpenSsl. > 5. Portable across various operating systems (currently only > Linux/MacOSX/Windows); Apache Commons Crypto loads the library > according to your machine environment (it checks system properties, > `os.name` and `os.arch`). > 6. Simple usage. Add the commons-crypto-(version).jar file to your > classpath. > > http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/3f6e5499/po > m.xml > ---------------------------------------------------------------------- > diff --git a/pom.xml b/pom.xml > index e3153e9..1d5c6af 100644 > --- a/pom.xml > +++ b/pom.xml > @@ -33,9 +33,9 @@ Features > -------- > > 1. Cipher API for low level cryptographic operations. > -2. Java stream API (CryptoInputStream/CryptoOutputStream) for high > level stream encyrption/decryption. > +2. Java stream API (CryptoInputStream/CryptoOutputStream) for high > +level > stream encryption/decryption. > 3. Both optimized with high performance AES encryption/decryption. > (1400 MB/s - 1700 MB/s throughput in modern Xeon processors). > -4. JNI-based implementation to achieve comparable performance to the > native C++ version based on OpenSsl. > +4. JNI-based implementation to achieve comparable performance to the > native C/C++ version based on OpenSsl. > 5. Portable across various operating systems (currently only > Linux/MacOSX/Windows); > Apache Commons Crypto loads the library according to your machine > environment (it checks system properties, `os.name` and `os.arch`). > 6. Simple usage. Add the commons-crypto-(version).jar file to your > classpath. > > > http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/3f6e5499/sr > c/site/resources/download_crypto.cgi > ---------------------------------------------------------------------- > diff --git a/src/site/resources/download_crypto.cgi > b/src/site/resources/download_crypto.cgi > index 3d6f003..8beea31 100644 > --- a/src/site/resources/download_crypto.cgi > +++ b/src/site/resources/download_crypto.cgi > @@ -1,5 +1,5 @@ > #!/bin/sh > # Just call the standard mirrors.cgi script. It will use > download.html # as the input template. > -exec /www/www.apache.org/dyn/mirrors/mlirrors.cgi $* > +exec /www/www.apache.org/dyn/mirrors/mirrors.cgi $* > > > > http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/3f6e5499/sr > c/site/site.xml > ---------------------------------------------------------------------- > diff --git a/src/site/site.xml b/src/site/site.xml index > 55d8d39..34e99c3 100644 > --- a/src/site/site.xml > +++ b/src/site/site.xml > @@ -26,7 +26,7 @@ > <menu name="Documentation"> > <item name="Overview" href="/index.html"/> > <item name="Download" > - href=" > http://commons.apache.org/crypto/download_crypto.cgi"/> > + href=" > http://commons.apache.org/proper/commons-crypto/download_crypto.cgi"/> > <item name="Users guide" href="/userguide.html"/> > <item name="Javadoc trunk" href="/apidocs/index.html"/> > </menu> > > > http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/3f6e5499/sr > c/site/xdoc/index.xml > ---------------------------------------------------------------------- > diff --git a/src/site/xdoc/index.xml b/src/site/xdoc/index.xml index > 68a4bb1..2cdb2fe 100644 > --- a/src/site/xdoc/index.xml > +++ b/src/site/xdoc/index.xml > @@ -42,9 +42,9 @@ limitations under the License. > </li> > <li>High performance AES encryption/decryption optimized with > Intel AES-NI. > </li> > - <li>Portable across various operating systems (currently only > Linux/Mac OS); Apache Commons Crypto loads the > - library according to your machine environment (It looks system > properties, os.name and > - os.arch). > + <li>Portable across various operating systems (currently only > Linux/Mac OS/Windows); Apache > + Commons Crypto loads the library according to your machine > environment (It looks system > + properties, os.name and os.arch). > </li> > <li>Simple usage. Add the commons-crypto-(version).jar file to > your classpath.</li> > </ul> > @@ -76,13 +76,13 @@ limitations under the License. > <section name="Releases"> > <ul> > <li> > - <a href="http://commons.apache.org/crypto/download_crypto.cgi";>Crypto > 1.0.0 (mirrors)</a> > + <a href=" > http://commons.apache.org/proper/commons-crypto/download_crypto.cgi";>C > rypto > 1.0.0 (mirrors)</a> > requires Java 1.7 > </li> > </ul> > <p> > See the > -<a > href="http://commons.apache.org/crypto/download_crypto.cgi";>Download > Page</a> > +<a href=" > http://commons.apache.org/proper/commons-crypto/download_crypto.cgi";>D > ownload > Page</a> > for the latest releases.<br /> > </p> > <p> > >
