@Rajiv: Gary was talking about this commit: https://github.com/apache/commons-io/pull/14/commits/be0477b5a571ec83d8b6554e898d3710f27bd153
BTW RuntimeException <https://docs.oracle.com/javase/8/docs/api/java/lang/RuntimeException.html> is an unchecked exception, no value in declaring them in Javadocs. and WRT the other question, deprecated meaning it will be removed later in the future. It's like a informed change that people should not use it. Thanks, Raviteja On Thu, Jul 21, 2016 at 3:39 AM, Rajiv Jain <rajiv...@gmail.com> wrote: > Hi Gary > > Where is this change? I cannot find it? > > In addition, would it be better to totally remove the closeQuietly() > method signature? As we are saying that it will be Deprecated, so people > should not use it. > > Let me know your thoughts so that I will make the relevant changes. > > Thanks. > > Regards, > Rajiv > > Sent from my iPhone > > > On 21 Jul 2016, at 05:15, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > Hi Rajiv, > > > > I added a "[Deprecated]" to the class comment for the closeQuietly() list > > item. > > > > I did not use the patch to use "Please note, that IOExceptions are caught > > but any RuntimeExceptions can be thrown from the close() method." > > > > It seems to me that a RuntimeException can be thrown from the guts of any > > method, especially like a close-like method, so I am not sure I see the > > value here. > > > > Perhaps others in the community feel otherwise and I invite them to make > a > > suitable change. I just do not see it needed from my POV. > > > > Thank you, > > Gary > > > >> On Mon, Jul 18, 2016 at 12:57 PM, Rajiv Jain <rajiv...@gmail.com> > wrote: > >> > >> Thanks Gary. I will be patient. > >> > >> Thanks for replying. > >> > >> Rajiv > >> > >>> On 18 Jul 2016, at 20:56, Gary Gregory <garydgreg...@gmail.com> wrote: > >>> > >>> Hello Rajiv, > >>> > >>> We are all volunteers working on a large project with many components > >> with > >>> different levels of activity. Please be patient. Hopefully someone will > >>> take a look at your request soon. > >>> > >>> Gary > >>> > >>>> On Mon, Jul 18, 2016 at 10:16 AM, Rajiv Jain <rajiv...@gmail.com > >>> <mailto:rajiv...@gmail.com>> wrote: > >>> > >>>> Hi > >>>> > >>>> I have been working on the Apache Maven project as a contributor > >> recently. > >>>> I don’t know whether it is any different for Apache Commons IO. > >>>> > >>>> The procedure for Apache Maven contributions are: > >>>> > >>>> a) Choose a Jira ticket to work on > >>>> b) Fork the project > >>>> 3) Make changes > >>>> 4) Apply a pull request > >>>> > >>>> For the issues that I have worked on, pull requests are reviewed. > >>>> > >>>> A few days ago, I worked on the Commons IO for IO-480 and removed some > >>>> Java documentation within the class files but no one has reviewed it. > >> Is it > >>>> the same process or have I missed something? The pull request is > located > >>>> here: https://github.com/apache/commons-io/pull/14 < > >>>> https://github.com/apache/commons-io/pull/14 < > >> https://github.com/apache/commons-io/pull/14>> > >>>> > >>>> In addition, if I would like to work on Apache Commons project where > is > >>>> the best place I can start. As, I looked at the Jira tickets and there > >> are > >>>> in open state and when looking into the code they have already been > >> fixed. > >>>> > >>>> Thanks. > >>>> > >>>> Regards, > >>>> Rajiv > >>> > >>> > >>> > >>> > >>> -- > >>> E-Mail: garydgreg...@gmail.com <mailto:garydgreg...@gmail.com> | > >> ggreg...@apache.org <mailto:ggreg...@apache.org> > >>> Java Persistence with Hibernate, Second Edition > >>> <http://www.manning.com/bauer3/ <http://www.manning.com/bauer3/>> > >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/ < > >> http://www.manning.com/tahchiev/>> > >>> Spring Batch in Action <http://www.manning.com/templier/ < > >> http://www.manning.com/templier/>> > >>> Blog: http://garygregory.wordpress.com < > >> http://garygregory.wordpress.com/> > >>> Home: http://garygregory.com/ <http://garygregory.com/> > >>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory> > > > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition > > <http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- *Raviteja Lokineni* | Business Intelligence Developer TD Ameritrade E: raviteja.lokin...@gmail.com [image: View Raviteja Lokineni's profile on LinkedIn] <http://in.linkedin.com/in/ravitejalokineni>
