On Mon, Jun 6, 2016 at 10:25 PM, Benedikt Ritter <benerit...@gmail.com> wrote:
> Hello Gary, > > Gary Gregory <garydgreg...@gmail.com> schrieb am Mo., 6. Juni 2016 um > 23:34 Uhr: > > > On Mon, Jun 6, 2016 at 8:53 AM, Benedikt Ritter <brit...@apache.org> > > wrote: > > > > > Hello Gary, > > > > > > unfortunately I have to vote -1 for two reasons: > > > > > > 1. tag name does not follow tag naming convention, although I brought > > this > > > up when the tag was created initially. Looking at the other tags, it > > should > > > be BEANUTILS_1_9_3_RC1 > > > > > > > How is that a blocker? As I wrote previously, I followed the directions > in > > https://commons.apache.org/releases/prepare.html. At some point, we just > > need to stick to one process for releasing... > > > > The guide says: > > "Create the RC tag, by copying the tag workspace to SVN as below. The tag > name should include the component name, as this makes it easier to > distinguish checkouts. Try to follow the existing naming convention so the > tag names will sort in a reasonable order. For example NET uses > NET_M_N_RC1, and LANG has a similar convention. For an example of how > *not* to > do it, see https://svn.apache.org/repos/asf/commons/proper/io/tags/ The IO > tags don't sort properly." They key word here is "Try". I did not because that's an extra useless step that is only cosmetic. The example in the instructions is what went by. If the text read "You MUST" then I would have done that. Gary > > Also I pointed out that the tag has the wrong name when it was created. > > > > > > > > > > > > 2. Build fails with: > > > > > > > See my reply to Stian. Same as 1.9.2, which does not make it right I > know. > > > > I think we should handle this like we handled the licensing problems for > CSV. Having it wrong for the last release doesn't justify having it wrong > for the next release. > > Benedikt > > > > > > Hm, CONTRIBUTING.md was also missing. > > > > Gary > > > > > > > > IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175 > Not > > > IndexedPropertyDescriptor expected:<class > > > java.beans.IndexedPropertyDescriptor> but was:<class > > > java.beans.PropertyDescriptor> > > > IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be > > cast > > > to java.beans.IndexedPropertyDescriptor > > > IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be > > cast > > > to java.beans.IndexedPropertyDescriptor > > > IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not > > > IndexedPropertyDescriptor expected:<class > > > java.beans.IndexedPropertyDescriptor> but was:<class > > > java.beans.PropertyDescriptor> > > > IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw exception > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be > > cast > > > to java.beans.IndexedPropertyDescriptor > > > IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw > exception > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be > > cast > > > to java.beans.IndexedPropertyDescriptor > > > IndexedPropertyTestCase.testListReadMethod:256 Threw exception > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be > > cast > > > to java.beans.IndexedPropertyDescriptor > > > IndexedPropertyTestCase.testListWriteMethod:274 Threw exception > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be > > cast > > > to java.beans.IndexedPropertyDescriptor > > > Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but > > > was:<java.[util.List]> > > > Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]> > > but > > > was:<java.[util.List]> > > > > > > when running on: > > > > > > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option > > > MaxPermSize=128m; support was removed in 8.0 > > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > > > 2015-11-10T17:41:47+01:00) > > > Maven home: /usr/local/Cellar/maven/3.3.9/libexec > > > Java version: 1.8.0_65, vendor: Oracle Corporation > > > Java home: > > > /Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre > > > Default locale: de_DE, platform encoding: UTF-8 > > > OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac" > > > > > > Thank you for pushing a new release! > > > Benedikt > > > > > > Gary Gregory <garydgreg...@gmail.com> schrieb am Fr., 3. Juni 2016 um > > > 02:24 Uhr: > > > > > > > Apache Commons BeanUtils 1.9.3 RC1 is available for review here: > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/beanutils/ > > > > (revision 13874) > > > > > > > > commons-beanutils-1.9.3-bin.tar.gz > > > > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709) > > > > commons-beanutils-1.9.3-bin.zip > > > > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3) > > > > commons-beanutils-1.9.3-src.tar.gz > > > > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06) > > > > commons-beanutils-1.9.3-src.zip > > > > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313) > > > > > > > > Maven artifacts are here: > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/ > > > > > > > > These are the artifacts and their hashes: > > > > > > > > commons-beanutils-1.9.3-test-sources.jar > > > > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f) > > > > commons-beanutils-1.9.3-sources.jar > > > > (SHA1: 53bae8809672897cb9954669775fb214623c6b89) > > > > commons-beanutils-1.9.3.pom > > > > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55) > > > > commons-beanutils-1.9.3.jar > > > > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c) > > > > commons-beanutils-1.9.3-javadoc.jar > > > > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf) > > > > commons-beanutils-1.9.3-tests.jar > > > > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b) > > > > > > > > Details of changes since 1.9.2 are in the release notes: > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt > > > > > > > > > > > > > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html > > > > > > > > > > > > The tag is here: > > > > > > > > > > > > > > https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/ > > > > (revision 1745420) > > > > > > > > Site: > > > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/ > > > > > > > > (some *relative* links are broken - these will be OK once the site > > > > is deployed) > > > > > > > > Clirr Report (compared to 1.9.2): > > > > > > > > > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html > > > > > > > > RAT Report: > > > > > > > > > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html > > > > > > > > KEYS: > > > > https://www.apache.org/dist/commons/KEYS > > > > > > > > Please review the release candidate and vote. > > > > > > > > This vote will close no sooner than 72 hours from now, i.e. sometime > > > after > > > > 18:00 PST 5 June 2016 > > > > > > > > > > > > [ ] +1 Release these artifacts > > > > [ ] +0 OK, but... > > > > [ ] -0 OK, but really should fix... > > > > [ ] -1 I oppose this release because... > > > > > > > > Thanks! > > > > Gary Gregory > > > > > > > > > > > > -- > > > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > > > Java Persistence with Hibernate, Second Edition > > > > <http://www.manning.com/bauer3/> > > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > > > Spring Batch in Action <http://www.manning.com/templier/> > > > > Blog: http://garygregory.wordpress.com > > > > Home: http://garygregory.com/ > > > > Tweet! http://twitter.com/GaryGregory > > > > > > > > > > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition > > <http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
