My vote: +1 (binding)

FYI - dist sha1 checksums according to svn r13750

6650d1c878b1142a0c8e3be3534ad24d6f422fc2
binaries/commons-fileupload-1.3.2-bin.tar.gz
0d1004f3aab4ecc62b2fb14056b9c92489d79121
binaries/commons-fileupload-1.3.2-bin.zip
6f254ad51f5e2c9d9a039995bc1a2295cabc95f6
source/commons-fileupload-1.3.2-src.tar.gz
10da7c5124b52d713da0f45b2f63ae9683e6591d
source/commons-fileupload-1.3.2-src.zip

Tested:

+1 signatures
+1 hashes
+1 mvn apache-rat:check
+1 mvn clean install
+1 zip vs tar.gz
+1 binary jar content matches target jar
+1 binary jar same checksum in maven repo
+1 -sources.jar matches src.tar
0 mvn site  (except site/index.html says latest is 1.3 instead of 1.3.1)
+1 LICENSE, NOTICE
+1 RELESE-NOTES
+1 PMD, CLR reports
+1 source matches svn tag (except download_fileupload.cgi and
doap_fileupload.rdf)


Tested with:

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-22-generic", arch: "amd64", family: "unix"

On 23 May 2016 at 16:23, Benedikt Ritter <brit...@apache.org> wrote:
> It has been a long time since the last release of Apache Commons
> FileUpload, so I'd like to release Apache Commons FileUpload 1.3.2 based on
> RC1.
>
> Apache Commons FileUpload 1.3.2 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/fileupload (rev 13750)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1173/commons-fileupload/commons-fileupload/1.3.2/
>
> These are the Maven artifacts and their hashes
>
> commons-fileupload-1.3.2-javadoc.jar
> (SHA1: 12bbb300a1b61e038defb1dee85e8302d6f1bbaa)
> commons-fileupload-1.3.2-sources.jar
> (SHA1: 23996750d5a80dc74dad55633c2a0f3db91462cb)
> commons-fileupload-1.3.2-test-sources.jar
> (SHA1: 2df285ad143910759a3763fcec0cd58e8525d881)
> commons-fileupload-1.3.2-tests.jar
> (SHA1: 310e3713308073a0392be30c129b55e872fe48f6)
> commons-fileupload-1.3.2,jar
> (SHA1: 5d7491ed6ebd02b6a8d2305f8e6b7fe5dbd95f72)
> commons-fileupload-1.3.2.pom
> (SHA1: a4c3e5d590c2e83bba42768c5b5fbef43219b5c4)
>
> Details of the change since 1.3.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/fileupload/RELEASE-NOTES.txt
>
> http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/changes-report.html
>
> I have tested this with:
>   JDK 1.6 and Maven 3.2.5
>   JDK 1.7 and Maven 3.3.9
>   JDK 1.8 and Maven 3.3.9
> Note that commons-fileupload should be JDK 1.5 compatible, but I don't have
> a JDK 1.5 installation on my MacBook. If someone could check the build with
> JDK 1.5, that would be great!
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/fileupload/tags/FILEUPLOAD_1_3_2_RC1
>  (rev 1745203)
>
> Site:
>   http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/
> (note some *relative* links are broken and the 1.3.2 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 1.3):
>
> http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/clirr-report.html
> (note that the API additions have been introduced in 1.3.1 not in 1.3.2)
>
> RAT Report:
>
> http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now,
> i.e. sometime after 17:30 CEST 26-May 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] +0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt



-- 
Stian Soiland-Reyes
Apache Commons, Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to