On 19 April 2016 at 17:07, Gary Gregory <garydgreg...@gmail.com> wrote: > Sebb, > > So you are migrating to the 3.5.1 site plugin anyway?
No, I was testing and committed in error. > It's fine with me. > Is the CDATA stuff compat with 3.4? It must be... Unfortunately not. Adding CDATA does not cause any processing errors, but the contents are lost with site 3.4 So for example the prettify code is just dropped. I had hoped it would be possible to make a start upgrading, but obviously it has to be done at the same time as changing the site plugin. And every component is going to have to check for footer/header sections. Hopefully there won't be many. But there's no point even attempting this until the Doxia error is sorted out (see comments in CP 40) AFAICT the Velocity change should be less intrusive. It looks like it should be possible to change the quoting in such a way as to be backwards compatible. And it's unlikely to be needed anyway. > Gary > > ---------- Forwarded message ---------- > From: <s...@apache.org> > Date: Tue, Apr 19, 2016 at 9:01 AM > Subject: svn commit: r1739951 - > /commons/proper/commons-parent/trunk/src/site/site.xml > To: comm...@commons.apache.org > > > Author: sebb > Date: Tue Apr 19 16:01:07 2016 > New Revision: 1739951 > > URL: http://svn.apache.org/viewvc?rev=1739951&view=rev > Log: > Revert accidental commit > > Modified: > commons/proper/commons-parent/trunk/src/site/site.xml > > Modified: commons/proper/commons-parent/trunk/src/site/site.xml > URL: > http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/site/site.xml?rev=1739951&r1=1739950&r2=1739951&view=diff > ============================================================================== > --- commons/proper/commons-parent/trunk/src/site/site.xml (original) > +++ commons/proper/commons-parent/trunk/src/site/site.xml Tue Apr 19 > 16:01:07 2016 > @@ -58,7 +58,6 @@ > > <body> > <head> > - <![CDATA[ > <!-- Better display of <source> code sections --> > <!-- Note: the $relativePath reference is resolved by the template > --> > <link rel="stylesheet" href="$relativePath/css/prettify.css" > type="text/css" media="all" /> > @@ -68,7 +67,6 @@ > prettyPrint(); > } > </script> > - ]]> > </head> > > <!-- N.B. body links are automatically inherited --> > > > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org