Thanks a lot for a thorough review ! This vote is cancelled for an immedieate respin.
Kristian 2015-12-26 18:34 GMT+01:00 Phil Steitz <phil.ste...@gmail.com>: > Sigs and hashes are good. > > Release contents are good. > > Ant and maven builds both tested on 1.7, 1.8. > > Coburta disease has been cured - tests run cleanly against the > release jar. > > Unfortunately, the NOTICE file still has not had the copyright date > updated. > > I think that is a blocker, so -1 from me. > > Not blocking: > > There are a couple of Checkstyle and Findbugs errors that should be > fixed or suppressed. I am not sure whether or not the Findbugs > errors indicate actual problems. If they do, these should be fixed; > otherwise suppression should be configured. > > Phil > > > > On 12/23/15 2:14 PM, Kristian Rosenvold wrote: > > We have fixed quite a few bugs and added some significant > > enhancements since commons-io was released, > > so I would like to release commons-io 2.5 > > > > commons-io 2.5 RC2 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision > 11732) > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1136 > > > > > > Details of changes since 2.4 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/io/RELEASE-NOTES.txt > > http://people.apache.org/~krosenvold/commons-io > > -2.5-RC2/changes-report.html > > < > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/changes-report.html > > > > > > I have tested this with JDK 1.6, 1.7 and 1.8, IBM JDK 1.6, IBM JDK 1.7 > > > > Users testing on Windows may want to take note of > > https://issues.apache.org/jira/browse/IO-490, which > > is an old issue causing intermittent failures on Windows that is > unchanged > > as of this release. > > > > > > The tag is here https://svn.apache.org/repos/asf/commons/proper/io/tags/ > > commons-io-2.5-RC > > < > https://svn.apache.org/repos/asf/commons/proper/io/tags/commons-io-2.5-RC1 > > > > 2 > > (r1721575) > > > > Site: > > http://people.apache.org/~krosenvold/commons-io-2.5-RC2/ > > <http://people.apache.org/~krosenvold/commons-io-2.5-RC1/> > > (note some *relative* links are broken and the 2.5 directories are > > not yet created - these will be OK once the site is deployed) > > > > > > Clirr Report (compared to 2.4): > > http://people.apache.org/~krosenvold/commons-io > > -2.5-RC2/clirr-report.html > > < > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/clirr-report.html> > > > > > > RAT Report: > > http://people.apache.org/~krosenvold/commons-io > > -2.5-RC2/rat-report.html > > <http://people.apache.org/~krosenvold/commons-io-2.5-RC1/rat-report.html > > > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner that 72 hours from now, i.e. after > > 23:00 CET 26-Dec 2015 > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > > > Kristian > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
