-1 But are the NOTICE files actually needed? What does the LICENSE file say? Indeed where are the related LICENSE files?
AFAICT from the ASM license: http://asm.ow2.org/asmdex-license.html there is no need to add anything to the NOTICE file, but of course there is a need to provide the appropriate LICENSE file for artifacts that include the ASM library. The NOTICE file is only for *required* notices, see: http://www.apache.org/dev/licensing-howto.html#mod-notice Note: in any case the files should not be marked executable. On 18 December 2015 at 23:38, <mben...@apache.org> wrote: > Author: mbenson > Date: Fri Dec 18 23:38:26 2015 > New Revision: 1720859 > > URL: http://svn.apache.org/viewvc?rev=1720859&view=rev > Log: > add custom NOTICE files for modules that shade ASM > > Added: > commons/proper/weaver/trunk/ant/NOTICE.txt (with props) > commons/proper/weaver/trunk/modules/NOTICE.txt (with props) > > Added: commons/proper/weaver/trunk/ant/NOTICE.txt > URL: > http://svn.apache.org/viewvc/commons/proper/weaver/trunk/ant/NOTICE.txt?rev=1720859&view=auto > ============================================================================== > --- commons/proper/weaver/trunk/ant/NOTICE.txt (added) > +++ commons/proper/weaver/trunk/ant/NOTICE.txt Fri Dec 18 23:38:26 2015 > @@ -0,0 +1,9 @@ > +Apache Commons Weaver > +Copyright 2012-2015 The Apache Software Foundation > + > +This product includes software developed at > +The Apache Software Foundation (http://www.apache.org/). > + > +Binary artifacts include portions of the ASM bytecode library: > +Copyright (c) 2000-2011 INRIA, France Telecom > + > > Propchange: commons/proper/weaver/trunk/ant/NOTICE.txt > ------------------------------------------------------------------------------ > svn:executable = * > > Added: commons/proper/weaver/trunk/modules/NOTICE.txt > URL: > http://svn.apache.org/viewvc/commons/proper/weaver/trunk/modules/NOTICE.txt?rev=1720859&view=auto > ============================================================================== > --- commons/proper/weaver/trunk/modules/NOTICE.txt (added) > +++ commons/proper/weaver/trunk/modules/NOTICE.txt Fri Dec 18 23:38:26 2015 > @@ -0,0 +1,9 @@ > +Apache Commons Weaver > +Copyright 2012-2015 The Apache Software Foundation > + > +This product includes software developed at > +The Apache Software Foundation (http://www.apache.org/). > + > +Binary artifacts include portions of the ASM bytecode library: > +Copyright (c) 2000-2011 INRIA, France Telecom > + > > Propchange: commons/proper/weaver/trunk/modules/NOTICE.txt > ------------------------------------------------------------------------------ > svn:executable = * > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
