On 24 November 2015 at 18:01, Phil Steitz <phil.ste...@gmail.com> wrote:
> On 11/24/15 7:11 AM, sebb wrote:
>> On 24 November 2015 at 13:52, Phil Steitz <phil.ste...@gmail.com> wrote:
>>> I need the following methods to complete the fix for MATH-1246. I
>>> can add them as private methods to the KS class; but they seem
>>> generally useful, so I propose adding them to MathArrays. Any
>>> objections?
>>>
>>> /**
>>> * Concatenates two arrays.
>>> *
>>> * @param x first array
>>> * @param y second array
>>> * @return a new array consisting of the entries of x followed by
>>> the entries of y
>>> * @throws NullPointerException if either x or y is null
>>> */
>>> public static double[] concat(double[] x, double[] y)
>> Could perhaps take a list?
>
> You mean what Gilles suggested?
Yes, not just a pair of arrays.
> Phil
>>
>>> /**
>>> * Returns an array consisting of the unique values in {@code data}.
>>> * The return array is sorted in descending order.
>>> *
>>> * @param data
>>> * @return descending list of values included in the input array
>>> */
>>> public static double[] values(double[] data)
>> The name gives no hint that the output is unique.
>> IMO it should be renamed to reflect that.
>>
>> [The sort order seems to be a byproduct of the algorithm used, so is
>> not particularly relevant to the name]
>>
>>> /**
>>> * Adds random jitter to {@code data} using deviates sampled from
>>> {@code dist}.
>>> * <p>
>>> * Note that jitter is applied in-place - i.e., the array
>>> * values are overwritten with the result of applying jitter.</p>
>>> *
>>> * @param data input/output data array
>>> * @param dist probability distribution to sample for jitter values
>>> * @throws NullPointerException if either of the parameters is null
>>> */
>>> public static void jitter(double[] data, RealDistribution dist)
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
