On 11/24/15 3:40 AM, Luc Maisonobe wrote: > Hi all, > > It seems the new bootstrap method introduced in fbc327e9 in order > to solve MATH-1246 creates some random test failures. > > The reason is that an EnumeratedRealDistribution instance is > created without a random generator (there are no way to pass > a random generator in the bootstrap method). This > EnumeratedRealDistribution will therefore create a Well19937c > generator with the default constructor, which uses time to seed > the generator. Depending on the way this generator is seeded, > the testBootstrapSmallSamplesWithTies test fails quite often. > > Would it be possible to pass a random generator somewhere and > to configure it with a fixed seed for the Junit tests?
I just changed the code (3_X: 3cfafe051 / master: 5f9cfa6eb) to have the bootstrap method use the rng configured for the class. The tests supply a fixed seed generator to the KS instance, but that was not being passed by the bootstrap to the EnumeratedDistribution. Sorry I missed that. Phil > > best regards, > Luc > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > . > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
