On Mon, Nov 9, 2015 at 10:37 AM, Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 08/11/2015 23:21, Thomas Neidhart a écrit :
>
> > please review the proposed fix for this issue here:
>
> The exception message ends with a comma, is this a typo? I suggest
> mentioning the system property in the message, such that someone
> hitting the exception immediately knows how to work around it.
>
yes, I wanted to add this information, but forgot to finish.
I also need to add a paragraph to the class javadoc outlining the change.
>
> Also:
>
> !"true".equalsIgnoreCase(deserializeProperty)
>
> is shorter than:
>
> deserializeProperty == null ||
> !deserializeProperty.equalsIgnoreCase("true")
>
yes indeed, will change too.
Thanks,
Thomas
