Hi.

(1)
I think that some methods defined in "MapUtils" do not belong there,
namely those aimed at visualizing a "NeuronSquareMesh2D".

Because "NeuronSquareMesh2D" is defined in "o.a.c.m.ml.neuralnet.twod",
the methods should be moved to a class (or several classes) defined
in that package too, or a sub-package ("util" or "visual"?) of it.

(2)
Some visualizations depend on the map topology; so it might be necessary to add methods in "NeuronSquareMesh2D" that expose the value of "wrapRows"
and "wrapColumns". [Not sure yet, (3) below, might be sufficient.]

(3)
A new method to select a neighbour in a certain "direction" (to be defined with an "enum") would be useful (for some visualizations that need the exact
location of each neighbour):
---CUT---
public class NeuronSquareMesh2D {
   // ...

   public enum HorizontalDirection {
       RIGHT, CENTER, LEFT,
   }
   public enum VerticalDirection {
       UP, CENTER, DOWN,
   }

   public Neuron getNeuronNeighbour(int i,
                                    int j,
                                    HorizontalDirection iDir,
                                    VerticalDirection jDir) {
       // ...
   }
}
---CUT---

Any objection or suggestion of better alternatives?


Regards,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to