2015-06-16 22:53 GMT+02:00 Gary Gregory <garydgreg...@gmail.com>:

> On Tue, Jun 16, 2015 at 2:36 AM, Benedikt Ritter <brit...@apache.org>
> wrote:
>
> > 2015-06-16 10:17 GMT+02:00 Gary Gregory <garydgreg...@gmail.com>:
> >
> > > On Mon, Jun 15, 2015 at 11:25 PM, Benedikt Ritter <brit...@apache.org>
> > > wrote:
> > >
> > > > You have to manually download the file and put it in the correct
> > > location.
> > > > It is only used during the OpenJMH tests. Here is the relevant
> snippet
> > > form
> > > > pom.xml:
> > > >
> > > > <!-- Not in Maven Central, download manually from
> > > > http://kasparov.skife.org/csv/csv-1.0.jar and copy in the base
> > directory
> > > > -->
> > > > <dependency>
> > > >   <groupId>org.skife.kasparov</groupId>
> > > >   <artifactId>csv</artifactId>
> > > >   <version>1.0</version>
> > > >   <scope>system</scope>
> > > >   <systemPath>${basedir}/csv-1.0.jar</systemPath>
> > > > </dependency>
> > > >
> > >
> > > That's too much work for very little gain :-(
> > >
> >
> > Yes, I don't see us rerunning this tests very often. I would prefer a
> > graphical performance comparison published on our website rather than the
> > additional complexity in the build files...
> >
>
> I think we need to either:
>
> - provide an Ant or Maven script to do the fiddling you describe, or

- dump this test
>
> Thoughts?


I would like to hear Emmanuel's opinion, since he originally developed the
test. Maybe his intention was to throw it away anyway. Downloading via
maven should be too hard with the maven-download-plugin [1].

Benedikt

[1] https://github.com/maven-download-plugin/maven-download-plugin


>
> Gary
>
> >
> >
> > >
> > > Gary
> > >
> > >
> > > >
> > > > Benedikt
> > > >
> > > > 2015-06-16 1:52 GMT+02:00 Gary Gregory <garydgreg...@gmail.com>:
> > > >
> > > > > It seems that the org.skife jar is not in Maven Central:
> > > > >
> > > > > [ERROR] Failed to execute goal on project commons-csv: Could not
> > > resolve
> > > > > dependencies for project
> > > > org.apache.commons:commons-csv:jar:1.1.1-SNAPSHOT:
> > > > > Could not find artifact org.skife.kasparov:csv:jar:1.0 at specified
> > > path
> > > > > C:\vcs\svn\apache\commons\trunks-prope
> > > > > r\csv\csv-1.0.jar -> [Help 1]
> > > > >
> > > > > Thoughts?
> > > > >
> > > > > Gary
> > > > >
> > > > > --
> > > > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > > > > Java Persistence with Hibernate, Second Edition
> > > > > <http://www.manning.com/bauer3/>
> > > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > > > Spring Batch in Action <http://www.manning.com/templier/>
> > > > > Blog: http://garygregory.wordpress.com
> > > > > Home: http://garygregory.com/
> > > > > Tweet! http://twitter.com/GaryGregory
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > http://people.apache.org/~britter/
> > > > http://www.systemoutprintln.de/
> > > > http://twitter.com/BenediktRitter
> > > > http://github.com/britter
> > > >
> > >
> > >
> > >
> > > --
> > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> > >
> >
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
> >
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to