On 4/28/15 6:20 AM, Phil Steitz wrote: > On 4/26/15 9:23 PM, Gary Gregory wrote: >> In I see: >> >> private String jmxNameBase = DEFAULT_JMX_NAME_PREFIX; >> >> Shouldn;t that be: >> >> private String jmxNameBase = DEFAULT_JMX_NAME_BASE; >> >> ? >> > There is a comment in the code indicating that we may want to > combine these two properties in 3.x. The RHS that looks more > natural would assign null, which I don't think we want to do. It > would be good to document a little more fully exactly how these > properties work from public API standpoint. The idea is to allow > the pool to self-register with default name if it is configured to > register itself and the user has not supplied naming info.
See POOL-298. I am inclined to agree now with Gary and the OP on that issue. Any objections to the change in that ticket? Phil > > Phil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
