+1 non-binding No new FindBugs, PMD or CPD issues, new site layout (with minor CSS adjustments I think) looks good, all tests pass. Environment: Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-15T06:29:23+13:00) Maven home: /opt/apache-maven-3.2.5 Java version: 1.8.0_45, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-oracle/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.16.0-36-generic", arch: "amd64", family: "unix"
There are some issues in SonarQube, but the only one that called my attention was catching exception and throwing a new one without including the old exception [1]. But maybe that's the intended behaviour? Cheers Bruno [1] https://analysis.apache.org/issues/search#issues=15472838-0deb-4ae9-8c53-db00a11cc2ad From: Benedikt Ritter <brit...@apache.org> To: Commons Developers List <dev@commons.apache.org> Sent: Monday, May 4, 2015 3:18 AM Subject: [VOTE] Release Apache Commons CLI 1.3 based on RC1 Hi, We have fixed quite a few bugs and added some significant enhancements since CLI 1.2 was released and the Groovy Project is asking for a new release, so I would like to release CLI 1.3. The most notable change is the introduction of a new API for creating Option instances. CLI 1.3 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/cli/ (svn revision 8797) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1090/ Details of changes since 1.2 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/cli/RELEASE-NOTES.txt http://people.apache.org/~britter/cli-1.3-RC1/changes-report.html I have tested this with JDK 6, 7 and 8 using maven 3. The tag is here: http://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.3-RC1/ (svn revision 1677410) Site: http://people.apache.org/~britter/cli-1.3-RC1/ (note some *relative* links are broken and the 1.2 directories are not yet created - these will be OK once the site is deployed) Clirr Report (compared to 1.2): http://people.apache.org/~britter/cli-1.3-RC1/clirr-report.html RAT Report: http://people.apache.org/~britter/cli-1.3-RC1/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now, i.e. after 06-May 2015, 17:30 CEST. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thanks! Benedikt -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
