2015-04-09 1:53 GMT+02:00 Stian Soiland-Reyes <st...@apache.org>:

> Looks great! The travis is nice as it also comments on pull requests.
>
>
> .. but .. why are all the README links for homepage, JavaDoc, etc. wrong?
>
> e.g.
> https://commons.apache.org/proper/commons-lang3
> https://commons.apache.org/proper/commons-lang3/download_lang3.cgi
> https://commons.apache.org/proper/commons-lang3/javadocs/api-release
> all 404.
>
> Removing any '3' solves it.
>

Short answer: I've forgotten to correct them, when I created the README.md

Long answer: we have several commons specific properties defined in our
build plugin [1]. We use those properties to generate parts of our website,
like the download paage, issue tracking page, mailing list page and of
corse README.md. For commons-lang the problem is, that the property
commons.component.id is set to commons-lang3 but for bulding up the links
it has to be commons-lang.

Thank you for fixing. I forgot to close the issue via commit comment. Can
you please close it?
Note that all ASF committers have write access to our source repositories
[2]. So if you feel like it, you can apply changes directly next time ;-)

Benedikt

[1] http://svn.apache.org/viewvc/commons/proper/commons-build-plugin/trunk/
[2] http://markmail.org/message/ylmw7qzx23br4ver


>
>
> On 8 April 2015 at 20:07, Benedikt Ritter <brit...@apache.org> wrote:
> > INFRA-9391 [1] has been resolved, and I've applied the necessary changes.
> > Have a look at the mirror [2]
> >
> > Benedikt
> >
> > [1] https://issues.apache.org/jira/browse/INFRA-9391
> > [2] https://github.com/apache/commons-lang
> >
> > 2015-04-06 18:39 GMT+02:00 Benedikt Ritter <brit...@apache.org>:
> >
> >> I've create an infra ticket for activating Travis CI and coveralls for
> >> Commons Lang [1]
> >>
> >> Benedikt
> >>
> >> [1] https://issues.apache.org/jira/browse/INFRA-9391
> >>
> >> 2015-03-18 10:33 GMT+01:00 Benedikt Ritter <brit...@apache.org>:
> >>
> >>>
> >>>
> >>> 2015-03-04 20:24 GMT+01:00 Gary Gregory <garydgreg...@gmail.com>:
> >>>
> >>>> On Wed, Mar 4, 2015 at 9:59 AM, Benedikt Ritter <brit...@apache.org>
> >>>> wrote:
> >>>>
> >>>> > 2015-03-03 21:51 GMT+01:00 Andy Seaborne <a...@apache.org>:
> >>>> >
> >>>> > > Sorry to interrupt - this is not a "for" or "against" comment but
> >>>> > > something I want to make sure was considered.
> >>>> > >
> >>>> > > Apache is independent of any commercial entity.
> >>>> > >
> >>>> > > For example, there was a discussion about the "github/forkme"
> stripe
> >>>> in
> >>>> > > project home pages.  The outcome was that it was too much like
> >>>> endorsing
> >>>> > > one commercial player.
> >>>> > >
> >>>> > > This isn't the same but some of those are commercial operations.
> >>>> Anything
> >>>> > > that implies endorsement of their services needs to be carefully
> >>>> handled.
> >>>> > >
> >>>> >
> >>>> > Good point. I don't think this will be an issue, but we should be
> >>>> sure. Who
> >>>> > can I talk to about this? legal@?
> >>>> >
> >>>>
> >>>> You can! :-) Since you've taken the lead on the badges, you could
> follow
> >>>> it
> >>>> through to @legal. You probably know more about them than the rest of
> us.
> >>>>
> >>>
> >>> I've asked on d...@community.apache.org [1]. Is this good enough for
> us?
> >>>
> >>> Benedikt
> >>>
> >>> [1] http://markmail.org/message/knnmqvaguaigjsu3
> >>>
> >>>
> >>>>
> >>>> Gary
> >>>>
> >>>>
> >>>> >
> >>>> >
> >>>> > >
> >>>> > >         Andy
> >>>> > >
> >>>> > >
> >>>> > > On 03/03/15 19:31, Benedikt Ritter wrote:
> >>>> > >
> >>>> > >> Hi all,
> >>>> > >>
> >>>> > >> as you probably know, I'm a big fan of github :-) I've added
> >>>> README.md
> >>>> > >> files to some of our components. It should make the github
> >>>> repositories
> >>>> > >> more welcoming for github contributors.
> >>>> > >> There are a variety of services available which integrate nicely
> >>>> with
> >>>> > >> github repositories:
> >>>> > >>
> >>>> > >> - Travis CI build service [1]
> >>>> > >> - coveralls.io coverage service [2]
> >>>> > >> - Latest maven release [3]
> >>>> > >> - shield.io license badge [4]
> >>>> > >>
> >>>> > >> This services can be activated and a nice badge can be added to
> the
> >>>> > >> README.md. I really like the combination of the travis and the
> >>>> coveralls
> >>>> > >> badge, because it will build and evaluate coverage for PR
> requests
> >>>> > >> automatically. This way you don't have to look at PR which break
> the
> >>>> > build
> >>>> > >> or have a negative impact on the coverage.
> >>>> > >>
> >>>> > >> I've activated these services for my commons-lang fork [5]. If
> >>>> nobody
> >>>> > has
> >>>> > >> objections, I would like to add this to the README.md generation
> >>>> target
> >>>> > in
> >>>> > >> the commons-build-plugin.
> >>>> > >>
> >>>> > >> Note that travis and converalls have to be activated by a INFRA.
> >>>> I've
> >>>> > >> already seen jira requests for this, which have been resolved by
> >>>> INFRA,
> >>>> > so
> >>>> > >> this should not be a problem.
> >>>> > >>
> >>>> > >> Regards,
> >>>> > >> Benedikt
> >>>> > >>
> >>>> > >> [1] http://travis-ci.org
> >>>> > >> [2] http://coveralls.io
> >>>> > >> [3] https://github.com/jirutka/maven-badges
> >>>> > >> [4] http://shield.io
> >>>> > >> [5] https://github.com/britter/commons-lang
> >>>> > >>
> >>>> > >>
> >>>> > >>
> >>>> > >
> >>>> > >
> ---------------------------------------------------------------------
> >>>> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >>>> > > For additional commands, e-mail: dev-h...@commons.apache.org
> >>>> > >
> >>>> > >
> >>>> >
> >>>> >
> >>>> > --
> >>>> > http://people.apache.org/~britter/
> >>>> > http://www.systemoutprintln.de/
> >>>> > http://twitter.com/BenediktRitter
> >>>> > http://github.com/britter
> >>>> >
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> >>>> Java Persistence with Hibernate, Second Edition
> >>>> <http://www.manning.com/bauer3/>
> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>>> Spring Batch in Action <http://www.manning.com/templier/>
> >>>> Blog: http://garygregory.wordpress.com
> >>>> Home: http://garygregory.com/
> >>>> Tweet! http://twitter.com/GaryGregory
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> http://people.apache.org/~britter/
> >>> http://www.systemoutprintln.de/
> >>> http://twitter.com/BenediktRitter
> >>> http://github.com/britter
> >>>
> >>
> >>
> >>
> >> --
> >> http://people.apache.org/~britter/
> >> http://www.systemoutprintln.de/
> >> http://twitter.com/BenediktRitter
> >> http://github.com/britter
> >>
> >
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons RDF (incubating)
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to