On 2/18/15 6:30 AM, Emmanuel Bourg wrote: >> [X] +1 Release these artifacts > Tested with OpenJDK 7 on Debian. > > The name of the isLogExpiredConnections() method in BasicDataSource and > BasicDataSourceMXBean looks a bit inconsistent with the other methods > returning a boolean. I would have picked getLogExpiredConnections > (similar to the getRemove*, getTest* and getLogAbandoned methods) or > isExpiredConnectionsLogged (similar to > isAccessToUnderlyingConnectionAllowed) instead.
Good point. If you or others feel strongly that this is too ugly, I can change and re-roll. Any other opinions on this? Thanks for the review! Phil > > Emmanuel Bourg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
