On Tue, Jan 27, 2015 at 4:54 AM, Kristian Rosenvold < kristian.rosenv...@gmail.com> wrote:
> I've run through all of our tests and the release looks good. > > The testcase should fail 1 in 1000 times as is and has been fixed. > > I'm +1 on the release as such (but we'd normally recut or leave this > decision to the RM....). > > I'd prefer a clean RC to give a positive vote. So I'll abstain for now. Gary > Krisian > > 2015-01-27 7:35 GMT+01:00 Kristian Rosenvold <kristian.rosenv...@gmail.com > >: > > Done in r1654980. > > > > This whole incident is a confirmation of murphys law; I must've run > > that test 500 times on my machine without failure =:) > > > > K > > > > > > 2015-01-27 0:10 GMT+01:00 Gary Gregory <garydgreg...@gmail.com>: > >> I see you changed the test but the code could benefit from a comment to > >> avoid a future regression back to this problem. > >> > >> Gary > >> > >> On Mon, Jan 26, 2015 at 4:52 PM, Kristian Rosenvold < > krosenv...@apache.org> > >> wrote: > >> > >>> Testcase fixed in r1654901 > >>> > >>> Kristian > >>> > >>> > >>> 2015-01-26 22:37 GMT+01:00 Kristian Rosenvold < > >>> kristian.rosenv...@gmail.com>: > >>> > 2015-01-26 22:27 GMT+01:00 Gary Gregory <garydgreg...@gmail.com>: > >>> >> Tests: > >>> >> > >>> >> Running: 'mvn clean site' gave me > >>> >> > >>> >> Failed tests: > >>> >> > >>> > ZipTestCase.testCopyRawZip64EntryFromFile:361->assertSameFileContents:414 > >>> >> arrays first differed at element [10]; expected:<-16> but was:<-15> > >>> > > >>> > The problem appears to be that time does not stand still, and every > >>> > now and then you can make "expected" and "actual" get different time > >>> > stamps (with the 2 second granularity of zip it takes a bit of "luck" > >>> > to hit the problem) > >>> > > >>> > The problem is within the testcase itself, and I'll fix this on > trunk. > >>> > > >>> > Kristian > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >> > >> > >> -- > >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > >> Java Persistence with Hibernate, Second Edition > >> <http://www.manning.com/bauer3/> > >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > >> Spring Batch in Action <http://www.manning.com/templier/> > >> Blog: http://garygregory.wordpress.com > >> Home: http://garygregory.com/ > >> Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
