On 14 January 2015 at 12:16, Thomas Neidhart <thomas.neidh...@gmail.com> wrote: > I think it would be good to add it by default with the option to disable it > on a component level. > > According to > http://mojo.codehaus.org/animal-sniffer-maven-plugin/plugin-info.html, the > minimum requirements are JDK 1.5 and maven 2.0, but I wonder if anybody > would use an older jdk to build a component.
Commons Parent 36 requires Maven 3.0 or higher which requires Java 1.5 or higher so that's not an issue for the plugin. I expect most developers to be using at least Java 6 now to actually run Maven. > Did you resolve the problems you had with Java on MacOS? No, I've not looked into it. I should probably add a comment to CP in the animal sniffer section. > Thomas > > On Wed, Jan 14, 2015 at 12:57 AM, sebb <seb...@gmail.com> wrote: > >> I've been experimenting with Animal Sniffer in NET as a basic check >> that the code does not try to use method etc which are not present in >> the target Java version. >> [For example, java.net.IDN requires Java 1.6+] >> >> Although the plugin is not fool-proof, it should help to check basic >> errors and allow developers to check code even if they don't have the >> requisite Java version installed. >> >> My question is - should it be included in Commons Parent? >> And if so, should it be enabled by default? >> >> There are various ways of including it: >> - inline. It can then be suppressed by defining animal.sniffer.skip >> - as a profile which is enabled by default, potentially disabled >> manually or by use of a resource file >> - as a profile which is disabled by default, but enabled manually of >> by use of a resource file >> >> The profile options would work a bit like Jacoc/Cobertura, but could >> be enabled by default rather than disabled by default. >> >> WDYT? >> >> I would favour a profile, enabled by default, as this does not add to >> the size of the main body of pom. >> >> Note: the build helper plugin can be used to automatically convert >> from the maven.compiler.target syntax (e.g. 1.6) to the Animal Sniffer >> signature syntax (e.g. java16) so there is no need to maintain a >> separate variable. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
