On 10 January 2015 at 14:13, Benedikt Ritter <brit...@apache.org> wrote: > I've not seen any development activity over the past few days, so I'm > assuming that 1.4.1 RC 3 can now be rolled out (which I will do tomorrow)
Yes, sorry, should have said I had finished. I've not checked Clirr, but I don't think I changed anything that would affect that. > Benedikt > > 2015-01-06 12:19 GMT+01:00 sebb <seb...@gmail.com>: > >> Just realised there are some issues with the IDN changes I added. >> >> 1) Maximum Length checking. This is currently done become conversion >> to punycode. >> It occurs to me that sites presumably need to be equally reachable by >> both punycode and Unicode URLs, so the maximum length check should >> come after conversion >> Further, the label length checking is done after conversion already >> >> 2) URL validation only converts http(s) URLs to punycode, but >> presumably should convert domains for all schemes? >> >> Will fix 1 now; 2 will take longer. >> >> >> On 6 January 2015 at 00:39, sebb <seb...@gmail.com> wrote: >> > On 6 January 2015 at 00:30, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> On Mon, Jan 5, 2015 at 9:09 AM, sebb <seb...@gmail.com> wrote: >> >> >> >>> On 5 January 2015 at 07:03, Benedikt Ritter <brit...@apache.org> >> wrote: >> >>> > Hi all, >> >>> > >> >>> > there have been some fixes in the last few days (mostly thanks to >> sebb) >> >>> and >> >>> > my feeling is, that we're ready to cut 1.4.1 RC3. >> >>> >> >>> Yes, I think it is in a stable state. >> >>> I have been checking the source with Java 1.4 on a Windows VM and it >> >>> passes. >> >>> >> >>> > If there is something left you would like to add, then please let me >> >>> know. >> >>> >> >>> I'm still wondering about VALIDATOR-235 - allowing IDN names. >> >>> >> >>> I've just updated the issue with two possible approaches. >> >>> >> >>> Assuming we want to do it at all, I favour the reflection approach, as >> >>> >> >> >> >> Bleh. Let's cut 1.4.1 ASAP, then update the platform requirement to >> Java 6 >> >> and put out a 1.5. >> > >> > Yes, that is the plan. >> > >> >> Gary >> >> >> >> >> >>> it is likely the one we would take if the code needed 1.6. >> >>> When the minimum of Java 1.6 is reached, the reflection code can >> >>> simply be removed. >> >>> If the code checks for non-ASCII content first, the reflection code >> >>> won't be used unnecessarily. >> >>> >> >>> I'll look into this shortly, but wait for confirmation before >> committing. >> >>> >> >>> > Otherwise I'll cut RC3 tonight or tomorrow. >> >>> >> >>> Thanks! >> >>> >> >>> > Regards, >> >>> > Benedikt >> >>> > >> >>> > -- >> >>> > http://people.apache.org/~britter/ >> >>> > http://www.systemoutprintln.de/ >> >>> > http://twitter.com/BenediktRitter >> >>> > http://github.com/britter >> >>> >> >>> --------------------------------------------------------------------- >> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> >>> For additional commands, e-mail: dev-h...@commons.apache.org >> >>> >> >>> >> >> >> >> >> >> -- >> >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> >> Java Persistence with Hibernate, Second Edition >> >> <http://www.manning.com/bauer3/> >> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> >> Spring Batch in Action <http://www.manning.com/templier/> >> >> Blog: http://garygregory.wordpress.com >> >> Home: http://garygregory.com/ >> >> Tweet! http://twitter.com/GaryGregory >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
