IMO we should fix this now for 1.4.1, isn't the fix already in trunk? We can then update to Java 5 for a 1.5 release.
Gary On Fri, Jan 2, 2015 at 3:44 AM, Benedikt Ritter <brit...@apache.org> wrote: > Hm, not sure how serious this is. Let's see what others think. My feeling > is that we can fix that in 1.4.2 or 1.5 > > Benedikt > > 2015-01-02 3:06 GMT+01:00 sebb <seb...@gmail.com>: > > > Sorry, the mistake is mine entirely. > > The code to download the file was wrong - it was not checking the > > length of the buffer when writing the output. > > > > The 9C entry is obviously wrong, as is the code in DomainValidatorTest. > > > > On 2 January 2015 at 00:06, sebb <seb...@gmail.com> wrote: > > > Just noticed that the IANA TLD list has changed. > > > > > > This should not matter, except that it has dropped "9C" and replaced it > > by > > > > > > -3DS443G > > > XN--3E0B707E > > > XN--45BRJ9C > > > > > > Looks like the "9C" entry was a mistake. > > > > > > Unfortunately that is now included in the internal database. > > > > > > I don't know how serious an issue this is. > > > > > > Note that the first replacement entry above "-3DS443G" also looks like > > > a mistake, it should probably be "XN--3DS443G" (which appears to be a > > > valid domain) > > > > > > The latest IANA list also has lots of duplicate entries - including > > > "WTF", which is quite appropriate! > > > > > > > > > On 1 January 2015 at 18:02, Benedikt Ritter <brit...@apache.org> > wrote: > > >> Hi all, > > >> > > >> we have fixed the issues which where found in RC1 so I'd like to call > a > > new > > >> vote to release Apache Commons Validator based on RC2. > > >> > > >> Changes from RC1: > > >> - [VALIDATOR-307] - isValid checks if the given address is only IPV4 > > >> address and not IPV6 > > >> - [VALIDATOR-347] - toLowerCase() method is Locale-sensitive and > should > > not > > >> be used > > >> - [VALIDATOR-348] - Update TLD list to latest version (Version > > 2014123000) > > >> - [VALIDATOR-336] - CUSIPCheckDigit thinks invalid CUSIP is valid. > > >> - [VALIDATOR-345] - ISINCheckDigit fails to reject invalid > (non-numeric) > > >> check digits > > >> - [VALIDATOR-346] - SedolCheckDigit fails to reject invalid > > (non-numeric) > > >> check digits > > >> - Removed STATUS.html > > >> - Added README.md to binary and source distribution > > >> - Fixed encoding of source files in build by setting commons.encoding > > >> property > > >> - Fixed JIRA report to contain the issues of the project > > >> - Reverted dependency to commons-beanutils to 1.8.3 since this is the > > >> latest JDK 1.4 compatible release > > >> - Added JDK requirements to release notes. > > >> > > >> Validator 1.4.1-RC2 is available for review here: > > >> https://dist.apache.org/repos/dist/dev/commons/validator/ (svn > > revision > > >> 7629) > > >> > > >> The tag is here: > > >> > > >> > > > http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_1_RC2/ > > >> (svn revision 1648888) > > >> > > >> Maven artifacts are here: > > >> > > >> > > > https://repository.apache.org/content/repositories/orgapachecommons-1073/commons-validator/commons-validator/1.4.1/ > > >> > > >> Details of changes since 1.4 are in the release notes: > > >> > > > https://dist.apache.org/repos/dist/dev/commons/validator/RELEASE-NOTES.txt > > >> > > >> I have tested this with JDK 1.6, 1.7 and 1.8 using maven 3.2.5. > > >> > > >> Site (some links my be broken but will be fixed when the site is > > deployed): > > >> http://people.apache.org/~britter/validator-1.4.1-RC2/ > > >> > > >> Clirr Report: > > >> > > http://people.apache.org/~britter/validator-1.4.1-RC2/clirr-report.html > > >> > > >> RAT Report: > > >> > http://people.apache.org/~britter/validator-1.4.1-RC2/rat-report.html > > >> > > >> Keys: > > >> https://www.apache.org/dist/commons/KEYS > > >> > > >> Please review this release candidate and vote. > > >> This vote will close no sooner than 72 hours from now, i.e. after > > >> 2015/01/04 19:00CET > > >> > > >> [ ] +1 Release these artifacts > > >> [ ] +0 OK, but... > > >> [ ] -0 OK, but really should fix... > > >> [ ] -1 I oppose this release because... > > >> > > >> Thanks! > > >> Benedikt > > >> > > >> > > >> -- > > >> http://people.apache.org/~britter/ > > >> http://www.systemoutprintln.de/ > > >> http://twitter.com/BenediktRitter > > >> http://github.com/britter > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
