On 2014-12-28, Kristian Rosenvold wrote: > 2014-12-28 11:35 GMT+01:00 Stefan Bodewig <bode...@apache.org>: >> On 2014-12-26, Kristian Rosenvold wrote:
>>> D) Look at performance in the "gather" phase. It's too slow right now, >>> even with my last commit on trunk. Consider moving the creation of the >>> LFH to the multithreaded parts and actually copy parts to the central >>> directory upon merging. Ideally, the "gather" phase should be just IO. >>> Maybe make the creation of the central directory a Deferred stream >>> too, preferably of the offloading type. >> As long as you only write to the central directory stream after you've >> completely written the entry (otherwise you may not know the sizes >> depending on the method and whether the backing store is seekable) this >> should be doable. > The nice thing about using ScatterZipOutputStream first is that we > know *everything* about sizes and crcs before we start writing the zip > file. Ah, yes, re-read ScatterZipOutputStrean again. >> May I ask sneaking in "prefer using delegation over inheritance where >> possible"? ;-) > OMG; I seem to have gone full circle on this. I have been deeply in > the "prefer delegation" camp for the last 15 years or so. For the last > year or so I have been exposed to "inheritance"-based extensions in > @dayjob, and it's rubbing off on me.... Welcome back :-) Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
