On 12/23/14 1:11 PM, sebb wrote: > On 23 December 2014 at 17:32, Phil Steitz <phil.ste...@gmail.com> wrote: >> Tag: >> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_3_RC1/
r1647682 >> >> Tags are not immutable; My tags are. > the vote thread needs the revision. > >> Release: >> https://dist.apache.org/repos/dist/dev/commons/pool/ r7545 > Likewise, the URL does not uniquely identify what artifacts are being voted > on. > A revision or hashes of the artifacts are needed. > > Also need link to KEYS file so can check the sigs My key has been on the commons KEYs file for 10+ years now. I would expect Commons PMC members to know where to grab that file. > >> Maven: >> https://repository.apache.org/content/repositories/orgapachecommons-1070 >> >> Site: >> http://people.apache.org/~psteitz/pool/pool-2.3-rc1/ >> >> Release notes: >> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt >> >> Votes, please. This vote will close in 72 hours (26-Dec 17:30 GMT) >> >> [ ] +1 Release this >> [ ] +0 Ok, but... >> [ ] -0 Really should fix... >> [X] -1 We should not release this RC > The code contains LinkedBlockingDeque which is based on 3rd party code. > There is no corresponding mention in the LICENSE file, this needs to be added. This is Apache Harmony code. The ASF license header is there in the source. Phil > > I'm not sure that there should be a mention in the NOTICE file. > There does not appear to be an attribution requirement. > Or was the attribution removed from existing code? > >> Thanks! >> >> Phil >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org