On 11/10/2014 02:16 PM, Gary Gregory wrote: > If we updated: > > public interface BinaryEncoder extends Encoder { > > /** > * Encodes a byte array and return the encoded data as a byte array. > * > * @param source > * Data to be encoded > * @return A byte array containing the encoded data > * @throws EncoderException > * thrown if the Encoder encounters a failure condition > during the encoding process. > */ > byte[] encode(byte[] source) throws EncoderException; > } > > to: > > public interface BinaryEncoder extends Encoder { > > /** > * Encodes a byte array and return the encoded data as a byte array. > * > * @param source > * Data to be encoded > * @return A byte array containing the encoded data > * @throws EncoderException > * thrown if the Encoder encounters a failure condition > during the encoding process. > */ > byte[] encode(byte[] source) throws EncoderException; > > byte[] encode(ByteBuffer source) throws EncoderException; > > } > > (and the same for BinaryDecoder)
why not make a NIOBinaryEncoder interface that extends BinaryEncoder and adds the new method? This would allow us to stay on the 1.x branch. Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org