Makes sense to me. Go for it!
2014-11-01 5:33 GMT+01:00 Damjan Jovanovic <dam...@apache.org>:
> Hi
>
> Is there some reason CSVPrinter.printRecords(final ResultSet
> resultSet) retrieves all fields from the ResultSet using
> ResultSet.getString(), which makes QuoteMode.NON_NUMERIC quote
> numbers?
>
> This seems to work a lot better:
>
> Index: src/main/java/org/apache/commons/csv/CSVPrinter.java
> ===================================================================
> --- src/main/java/org/apache/commons/csv/CSVPrinter.java (revision
> 1635890)
> +++ src/main/java/org/apache/commons/csv/CSVPrinter.java (working copy)
> @@ -512,7 +512,7 @@
> }
> while (resultSet.next()) {
> for (int i = 1; i <= columnCount; i++) {
> - print(resultSet.getString(i));
> + print(resultSet.getObject(i));
> }
> println();
> }
>
>
> Can I commit?
>
> Thank you
> Damjan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
