All,

I have restored the original files but added deprecation and accuracy
warnings.  The new interpolators are now in their own "Piecewise" surnamed
classes.  All tests in the entire JUnit suite passed.

You can find the details of the pull request here:

https://github.com/apache/commons-math/pull/3

You can browse my version of the repository, or pull your own copy down,
here:

https://github.com/HankG/commons-math

This pull request seems to also have all of the changes from apache:master
that I fetched and merged with my local repository before I started these
edits.  I'm not sure how to get GitHub to ignore those came from the root,
nor have I figured out how to select a limited range of changes to get
around that.  I also don't want to let my fork go stale.  Between the two I
figured it was better to keep my fork up to date before making changes than
it was for the person processing a pull request to try to shoe horn it into
whatever the change is.

Along with these changes I did do a scan of my code to make sure I didn't
miss any defensive programming practices, used magic numbers, et cetera.
Nothing stood out to me, but proofreading your own writing is never a good
thing.  If whatever "minor changes" I need to make to get this code "on par
with what we had usually committed as new contributions" can be pointed out
here or in JIRA I'd appreciate it.

I'm adding this same note to the JIRA incident.

Hank

Reply via email to