On 10/10/2014 10:24 PM, Ole Ersoy wrote: > Hi, > > I ran the following assertions on the dice distribution in the > AbstractIntegerDistributionTest: > > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(0.7d/6d)); //Expecting 1 > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(0.8d/6d)); //Expecting 1 > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(0.9d/6d)); //Expecting 1 > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(1d/6d)); //Expecting 2 > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(1.5d/6d)); //Expecting 2 > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(2d/6d)); //Expecting 2 > > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(2.9d/6d)); //Expecting 3 > Assert.assertEquals(3, > diceDistribution.inverseCumulativeProbability(3.0d/6d)); //Expecting 4 > Assert.assertEquals(4, > diceDistribution.inverseCumulativeProbability(3.1d/6d)); > > Assert.assertEquals(4, > diceDistribution.inverseCumulativeProbability(3.2d/6d)); > Assert.assertEquals(4, > diceDistribution.inverseCumulativeProbability(3.5d/6d)); > > Assert.assertEquals(4, > diceDistribution.inverseCumulativeProbability(4.0d/6d)); //Expecting 5 > Assert.assertEquals(4, > diceDistribution.inverseCumulativeProbability(5.0d/6d)); //Expecting 5 > Assert.assertEquals(4, > diceDistribution.inverseCumulativeProbability(5.1d/6d)); //Expecting 5 > Assert.assertEquals(5, > diceDistribution.inverseCumulativeProbability(5.5d/6d)); > Assert.assertEquals(6, > diceDistribution.inverseCumulativeProbability(6.0d/6d)); > > All of them pass. Thoughts?
The variance of the DiceDistribution is wrong. Correct is the following: 2.91 or (70/24). You can verify the correct results also with a UniformIntegerDistribution(1, 6). Obviously the wrong variance was not noticed as the tests in this class do not compute the inverseCumulativeProbability. Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
