Using *ing and *ed versions are worse IMO. *ed like
isHeaderRecordSkipped makes it sound like we are asking if something has
happened in the past. *ing (
isSkippingHeaderRecord) makes is sounds like you are controlling something
that is happening right now.
I think it might make the getter methods less odd if we go back to using
the "get" prefix. It will make code completion nicer to boot.
Can we go back to use "get"?
Gary
On Sat, Jul 19, 2014 at 5:11 AM, Benedikt Ritter <brit...@apache.org> wrote:
> ... moving this to a new thread.
>
> so how do we reach consensus here? :o)
>
> if(format.isSkippingHeaderRecord()) {
> ...
> }
>
> sounds better to me than
>
> if(format.isHeaderRecordSkipped) {
> ...
> }
>
> Gary made up a good argument about using active voice in method names. How
> ever there will be the asymmetry because we're not using Java Bean
> conventions here...
>
> Benedikt
>
> 2014-07-19 0:17 GMT+02:00 Gary Gregory <garydgreg...@gmail.com>:
>
> > On Fri, Jul 18, 2014 at 4:36 PM, Emmanuel Bourg <ebo...@apache.org>
> wrote:
> >
> > > Le 18/07/2014 22:17, Benedikt Ritter a écrit :
> > > > Just to make it clear... We're happy with:
> > > > - boolean isIgnoringSurroundingSpaces()
> > > > - withIgnoreSurroundingSpaces(boolean)
> > > >
> > > > So nothing has to change?
> > >
> > > Not sure, I find the asymmetry a bit disturbing, but if I'm the only
> one
> > > I can pass on that.
> > >
> > > I still feel better with the -ed form:
> > >
> > > withHeaderSkipped()
> > > isHeaderSkipped()
> > >
> >
> > Yikes! That does not sounds good to me.
> >
> > It is likely that we will not find a good set of names that sound good
> with
> > the 'with' prefix, as a getter, and as a standalone ivar name.
> >
> > Gary
> >
> >
> > >
> > > Emmanuel Bourg
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > >
> >
> >
> > --
> > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
