On Fri, Jul 11, 2014 at 8:39 AM, Benedikt Ritter <brit...@apache.org> wrote:
> 2014-07-11 14:03 GMT+02:00 Gary Gregory <garydgreg...@gmail.com>: > > > On Fri, Jul 11, 2014 at 5:52 AM, Benedikt Ritter <brit...@apache.org> > > wrote: > > > > > Before I cut the RC... we currently have some unapproved files in our > RAT > > > report. These are all test data files located under src/test/resources. > > It > > > makes no sense to add a license header here. Should I exclude those > files > > > via RAT configuration? > > > > > > > I wonder if we should cherry pick and document in the POM's RAT section. > > > > For example, we would not add a header to src/test/resources/ferc.gov/ > > contract.txt but could add headers to some others if test pass as it. > > > > I would be best to have the least amount of files without a header and > > document why others have no headers in the POM. > > > > Thoughts? > > > > We're talking about test input like [1]. Does this really have to come with > a license header? How could we test CSVFormats with commenting disabled > then? That's why I suggested cherry picking. To reiterate: File that can have a header without breaking tests, should. Others, should be documented as excluded in the POM's RAT configuration. Gary I'd say we add an exclusion and document in NOTICE why those files > don't need a license (because they are plain test data...) > > br, > Benedikt > > [1] > > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/resources/CSVFileParser/test_default.txt?view=markup > > > > > > Gary > > > > > > > > TIA! > > > Benedikt > > > > > > > > > 2014-07-10 22:55 GMT+02:00 Gary Gregory <garydgreg...@gmail.com>: > > > > > > > Thank you for the update. > > > > > > > > See you tomorrow then. > > > > > > > > Gary > > > > > > > > > > > > On Thu, Jul 10, 2014 at 4:26 PM, Benedikt Ritter <brit...@apache.org > > > > > > wrote: > > > > > > > > > Hi. > > > > > > > > > > I've updated trunk and created the RC tag. currently I'm unable to > > > deploy > > > > > to nexus, probably because my environment isn't configured > correctly. > > > > I'll > > > > > have to dig into that tomorrow. Hopefully I'll be able to populate > > the > > > > > staging repo then :-) > > > > > > > > > > Good night! > > > > > Benedikt > > > > > > > > > > -- > > > > > http://people.apache.org/~britter/ > > > > > http://www.systemoutprintln.de/ > > > > > http://twitter.com/BenediktRitter > > > > > http://github.com/britter > > > > > > > > > > > > > > > > > > > > > -- > > > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > > > Java Persistence with Hibernate, Second Edition > > > > <http://www.manning.com/bauer3/> > > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > > > Spring Batch in Action <http://www.manning.com/templier/> > > > > Blog: http://garygregory.wordpress.com > > > > Home: http://garygregory.com/ > > > > Tweet! http://twitter.com/GaryGregory > > > > > > > > > > > > > > > > -- > > > http://people.apache.org/~britter/ > > > http://www.systemoutprintln.de/ > > > http://twitter.com/BenediktRitter > > > http://github.com/britter > > > > > > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition > > <http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
