Hello Thomas, thanks for pushing out this RC! I've reviewed this RC using maven 3.2.2 with Oracle JDK 1.8.0_05 and Oracle JDK 1.7.0_60.
- builds fine from sources - hashes and signs are good - Reports and site look good One minor nit: The source archives differ from the tag. It looks like the value inserted for the SVN id keyword is localized differently [1]. Since this doesn't affect the code itself I don't consider this a blocker. my +1 Regards, Benedikt [1] https://paste.apache.org/kxiy 2014-07-05 20:37 GMT+02:00 Thomas Neidhart <thomas.neidh...@gmail.com>: > This is a vote to release Commons Logging 1.2 based on RC2. > > Changes since RC2: > > * added pmd.xml to the source distribution > * added README.txt which describes how to properly build logging > > > This release drops support for Java 1.1, mainly to address LOGGING-37. > > Logging 1.2 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/logging/ > (svn revision 5755) > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1038/commons-logging/commons-logging/1.2/ > > Details of changes since 1.1.3 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/logging/RELEASE-NOTES.txt > > http://people.apache.org/builds/commons/logging/1.2/RC2/changes-report.html > > The tag is here: > > > > https://svn.apache.org/repos/asf/commons/proper/logging/tags/LOGGING_1_2_RC2/ > (svn 1608106) > > Site: > http://people.apache.org/builds/commons/logging/1.2/RC2/ > (note some *relative* links are broken and some new directories are > not yet created - these will be OK once the site is deployed) > > KEYS: > http://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
