Hello Thomas, thanks for working on this release. I've reviewed with maven 3.2.2 using Oracle JDK 1.8.0_05 and Oracle JDK 1.7.0_60
- builds fine from sources - source archives have the same content as the tag - Signs and hashes are good - Site and reports look good One minor nit: The RELEASE-NOTES.txt doesn't contain jira issue EMAIL-140, which is listed in the changes report. Since this change only affects users building from sources using Java 8, I don't it's super critical that it is listed there. my +1 Regards, Benedikt 2014-07-05 17:42 GMT+02:00 Thomas Neidhart <thomas.neidh...@gmail.com>: > This is a vote to release Commons Email 1.3.3 based on RC2. > > Changes since RC1: > > * fix test execution with Java 8 > * fix javadoc generation with Java 8 > > > Email 1.3.3 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/email/ > (svn revision 5753) > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/orgapachecommons-1037/org/apache/commons/commons-email/1.3.3/ > > Details of changes since 1.3.2 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/email/RELEASE-NOTES.txt > > http://people.apache.org/builds/commons/email/1.3.3/RC2/changes-report.html > > The tag is here: > > > https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_3_RC2/ > (svn 1608038) > > Site: > http://people.apache.org/builds/commons/email/1.3.3/RC2/ > (note some *relative* links are broken and some new directories are > not yet created - these will be OK once the site is deployed) > > KEYS: > http://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
