Hello, I did some chekcs on the CSV trunk cause you mentioned a release is coming up (and I feel its a bad feeling to get no external reviews for releases). Here are my findings:
- compiling with Java 8 and maven 3.2.1 on Windows works, but the site goal fails (findbugs porblem) - site: produces the "there are no official downloads, and will nut until version 1.0 is released". I guess this has to be changed before release. (some other places as well) - site: reportin bugs -> "commons sandbos project" - looks like it has its own JIRA component already? - site: team: 3 members with no avatars (mvdb, yonik, ggregory) - site: Netcetera company is mentioned in the "About" history page but not in the contributors. The 3 projects which are intentet to be obsoleted, is that message still agreed by them? Maybe all 3 authors should approve the release as well? - pom: display-plugin-updates: would be possible to update checkstyle from 1.12 to 1.12.1 - pom: display-dependency-updates: commons.io 2.2->2.4 and h2 1.3.168->1.4.178. Both are explained in the POM as last 1.5 dependency. Will we ship it as 1.5? - site/report: jira-report shows only one issue for 1.x, change to 1.0? (csv-64) - checkstyle: one linebreak error - parse(final File file, final CSVFormat format): as FindBugs complains it uses the default encoding in file reader. I can understand that this is for compatibility reasons but it is not at all mentioned in the javadoc. - there are 10 TODO tags in the source? - pom: there is one comment about using checkstyle 2.9.1 instead of 2.10 but the actual property is 2.12? -> remove comment? - pom: the javancss plugin seems to have a problem with maven 2, will we document minimum of maven 3.0.5? - pom: how will the release (assembly) be triggered? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
