On 05/01/2014 03:03 PM, sebb wrote:
> On 1 May 2014 12:05,  <t...@apache.org> wrote:
>> Author: tn
>> Date: Thu May  1 11:04:59 2014
>> New Revision: 1591602
>>
>> URL: http://svn.apache.org/r1591602
>> Log:
>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow 
>> sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
> 
> -1
> 
> I don't think this is a good idea.
> 
> See my comments on the JIRA issue.

I consider this to be a compromise considering the fact that previously
the util classes all had a public constructor.

So when people are migrating from 3.2.1 to 4.0, they have some troubles.
To ease the migration I thought that making it protected is safe:

 * it can not be instantiated
 * if somebody wants to sub-class: at your own risk, like before

The composition approach is the right way to go, and I would personally
never do something like the issue originator.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to