Hello Mark,

the build works fine from sources in my env:

Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T18:37:52+01:00)
Maven home: /usr/local/Cellar/maven/3.2.1/libexec
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.2", arch: "x86_64", family: "mac"

I've found one strange thing. When comparing the contents of the src.tar.gz
with the tag I get the following output:

bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff -q
commons-dbcp2-2.0-src DBCP_2_0_RC1/
Only in DBCP_2_0_RC1/: .svn
Files commons-dbcp2-2.0-src/LICENSE.txt and DBCP_2_0_RC1/LICENSE.txt differ
Files commons-dbcp2-2.0-src/NOTICE.txt and DBCP_2_0_RC1/NOTICE.txt differ
Files commons-dbcp2-2.0-src/README.txt and DBCP_2_0_RC1/README.txt differ
Files commons-dbcp2-2.0-src/build.properties.sample and
DBCP_2_0_RC1/build.properties.sample differ
Files commons-dbcp2-2.0-src/build.xml and DBCP_2_0_RC1/build.xml differ
Files commons-dbcp2-2.0-src/checkstyle.xml and DBCP_2_0_RC1/checkstyle.xml
differ
Only in DBCP_2_0_RC1/: doap_dbcp.rdf
Common subdirectories: commons-dbcp2-2.0-src/doc and DBCP_2_0_RC1/doc
Files commons-dbcp2-2.0-src/findbugs-exclude-filter.xml and
DBCP_2_0_RC1/findbugs-exclude-filter.xml differ
Files commons-dbcp2-2.0-src/pom.xml and DBCP_2_0_RC1/pom.xml differ
Common subdirectories: commons-dbcp2-2.0-src/src and DBCP_2_0_RC1/src
Files commons-dbcp2-2.0-src/test-jar.xml and DBCP_2_0_RC1/test-jar.xml
differ

And for all the differing files the result is:

bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff
commons-dbcp2-2.0-src/LICENSE.txt DBCP_2_0_RC1/LICENSE.txt
202c202
<    limitations under the License.
\ No newline at end of file
---
>    limitations under the License.

Can this be caused by the SVN checkout? I don't understand this.

- The signs look good.
- Site looks good.
- Test coverage is very low (below 50% in some of the packages)
- Maybe we can add PMD and CPD after this release?

If there is an explanation for the differing files, you have my +1 :-)

Benedikt



2014-02-27 20:42 GMT+01:00 Mark Thomas <ma...@apache.org>:

> It has been a while since it was first suggested but we have reached the
> point where DBCP 2.0 is ready for release.
>
> The significant changes are:
> - switched to Pool 2 for better performance
> - added JMX support
>
> We have also fixed quite a few bugs
>
> DBCP 2.0 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/dbcp/
>   (svn revision 4529)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1011/
>
> Details of changes since 1.x are in the release notes and changelog:
>   https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/changes-report.html
>
> The tag is here:
>   http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_0_RC1/
>   (svn revision 1572625)
>
> Site:
>   http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/index.html
>   (NB Javadoc links won't work - they'll find fine when deployed)
>
> KEYS:
>   http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to