Are we sure we want to do this in DBCP? If GOP ever changes defaults, DBCP will not pick this up.
Phil On 2/25/14, 9:57 AM, ggreg...@apache.org wrote: > Author: ggregory > Date: Tue Feb 25 17:57:47 2014 > New Revision: 1571774 > > URL: http://svn.apache.org/r1571774 > Log: > Access constant directly. > > Modified: > > commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java > > Modified: > commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java > URL: > http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java?rev=1571774&r1=1571773&r2=1571774&view=diff > ============================================================================== > --- > commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java > (original) > +++ > commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java > Tue Feb 25 17:57:47 2014 > @@ -571,7 +571,7 @@ public class BasicDataSource > * throwing an exception, or <= 0 to wait indefinitely. > */ > private long maxWaitMillis = > - GenericObjectPoolConfig.DEFAULT_MAX_WAIT_MILLIS; > + BaseObjectPoolConfig.DEFAULT_MAX_WAIT_MILLIS; > > /** > * <p>Returns the maximum number of milliseconds that the pool will wait > @@ -777,7 +777,7 @@ public class BasicDataSource > * be run. > */ > private long timeBetweenEvictionRunsMillis = > - GenericObjectPoolConfig.DEFAULT_TIME_BETWEEN_EVICTION_RUNS_MILLIS; > + BaseObjectPoolConfig.DEFAULT_TIME_BETWEEN_EVICTION_RUNS_MILLIS; > > /** > * Returns the value of the {@link #timeBetweenEvictionRunsMillis} > @@ -809,7 +809,7 @@ public class BasicDataSource > * evictor thread (if any). > */ > private int numTestsPerEvictionRun = > - GenericObjectPoolConfig.DEFAULT_NUM_TESTS_PER_EVICTION_RUN; > + BaseObjectPoolConfig.DEFAULT_NUM_TESTS_PER_EVICTION_RUN; > > /** > * Returns the value of the {@link #numTestsPerEvictionRun} property. > @@ -842,7 +842,7 @@ public class BasicDataSource > * is eligible for eviction by the idle object evictor (if any). > */ > private long minEvictableIdleTimeMillis = > - GenericObjectPoolConfig.DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS; > + BaseObjectPoolConfig.DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS; > > /** > * Returns the {@link #minEvictableIdleTimeMillis} property. > @@ -877,7 +877,7 @@ public class BasicDataSource > * parameter. See {@link #getSoftMinEvictableIdleTimeMillis()}. > */ > private long softMinEvictableIdleTimeMillis = > - GenericObjectPoolConfig.DEFAULT_SOFT_MIN_EVICTABLE_IDLE_TIME_MILLIS; > + BaseObjectPoolConfig.DEFAULT_SOFT_MIN_EVICTABLE_IDLE_TIME_MILLIS; > > /** > * Sets the minimum amount of time a connection may sit idle in the pool > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
