On Tue, Feb 18, 2014 at 4:09 AM, Mark Thomas <ma...@apache.org> wrote:
> On 18/02/2014 05:01, Gary Gregory wrote: > > Since you'll reroll the RC to fix the release notes for the version, you > > might has well update to commons-parent 33 to pick up the new skin. > > Why do I need to reroll the RC to fix the release notes? Because the RN file is part of the release, specifically, the source zip, which is the primary artifact that the ASF releases. The tag should reflect what we publish for a given RC. The tag for the 2.2 RC will be a copy of the tag for the RC that was voted on and passed. That tag should include the release notes with the label "2.2", not "2.1". Hence the request to have it all in sync. It's not the first time that a new RC would include a fix for the release notes. Gary The only issue > you identified was I hadn't replaced the 2.1 release notes with the 2.2 > release notes when I uploaded the files to /dist/dev (which has now been > done). > > Mark > > > > > Gary > > > > > > On Mon, Feb 17, 2014 at 3:42 PM, Mark Thomas <ma...@apache.org> wrote: > > > >> 2.2 fixes a few bugs and adds a new testOnCreate() feature that is > >> required by DBCP 2. > >> > >> > >> The Pool 2.2 RC1 is available for review here: > >> https://dist.apache.org/repos/dist/dev/commons/pool/ (r4424) > >> > >> Maven artifacts are here: > >> > https://repository.apache.org/content/repositories/orgapachecommons-1008 > >> > >> Details of changes since 2.1 are in the release notes and changelog: > >> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt > >> > >> > http://people.apache.org/~markt/dev/pool-2.2-RC1-site/changes-report.html > >> > >> The tag is here: > >> > http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_2_RC1/ > >> (r 1569090) > >> > >> Site: > >> http://people.apache.org/~markt/dev/pool-2.2-RC1-site > >> (Broken links to Javadoc versions expected) > >> > >> KEYS: > >> http://www.apache.org/dist/commons/KEYS > >> > >> Please review the release candidate and vote. > >> This vote will close no sooner than 72 hours from now > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > >> > >> > >> Cheers, > >> > >> Mark > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory