On Thu, Feb 6, 2014 at 6:40 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
> Downloaded tag and build with 'mvn clean site', builds OK, reports looks > good (aside from the quirk already mentioned WRT > src/checkstyle/license-header.txt) > I also did the same with good results with the src zip file. Gary > > The main site page, under "Full releases" is missing an entry for 1.3.1. I > usually make the RC date the release date (when I RM). > > It would be good to add a code coverage report. > > Javadoc warnings: > > [WARNING] warning: [options] bootstrap class path not set in conjunction > with -source 1.5 > [WARNING] > C:\temp\rc\FILEUPLOAD_1_3_1_RC1\src\main\java\org\apache\commons\fileupload\FileUploadBase.java:1367: > warning - Tag @link: can't find SizeLimitExceededException(String, l > ong, long) in > org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException > [WARNING] > C:\temp\rc\FILEUPLOAD_1_3_1_RC1\src\main\java\org\apache\commons\fileupload\FileUploadBase.java:1377: > warning - Tag @link: can't find SizeLimitExceededException(String, l > ong, long) in > org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException > > No showstoppers: [X] +1 Release these artifacts. > > My set up: > > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 > 11:22:22-0400) > Maven home: C:\Java\apache-maven-3.1.1\bin\.. > Java version: 1.7.0_51, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_51\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > Gary > > > On Thu, Feb 6, 2014 at 1:04 PM, Mark Thomas <ma...@apache.org> wrote: > >> The FileUpload 1.3.1 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/fileupload/ (r4317) >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1005/ >> >> Details of changes since 1.3 are in the release notes and changelog: >> >> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/RELEASE-NOTES.txt >> >> >> >> http://people.apache.org/~markt/dev/fileupload-1.3.1-RC1-site/changes-report.html >> >> The tag is here: >> >> >> http://svn.apache.org/viewvc/commons/proper/fileupload/tags/FILEUPLOAD_1_3_1_RC1/ >> (r 1565352) >> >> Site: >> http://people.apache.org/~markt/dev/fileupload-1.3.1-RC1-site >> (Broken links to Javadoc versions expected) >> >> KEYS: >> http://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> >> Since 1.3.1 includes a security fix to a vulnerability rated as >> important this vote will close at the discretion of the release manager. >> It is very likely to be shorter than the normal 72 hours. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> >> Cheers, >> >> Mark >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second > Edition<http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
