On 05/02/2014 11:26, sebb wrote: > This fails due to a class cast exception. > > I think the problem is in > > PoolingConnection.createKey(String sql, byte stmtType) > > > which calls > > return new PStmtKey(normalizeSQL(sql), catalog, stmtType); > > However PStmtKey expects the 3rd paraneter to be int autoGeneratedKeys > > I think stmtType should probably be an enum to avoid it being mistaken > for an int. > > Possibly some of the PStmtKey ctors should be removed or made private > to avoid unexpected conversions of the wrong param. > > Also, they definitely need Javadocs - it looks like the wrong PStmtKey > ctor is being called here.
Agree on the enum. I'll get that and the actual problem fixed shortly. Mark > > > ---------- Forwarded message ---------- > From: Apache Continuum <d...@continuum.apache.org> > Date: 5 February 2014 10:22 > Subject: [continuum] BUILD FAILURE: Apache Commons DBCP - Apache > Commons (Project Maven 2 Build Definition (Java 1.7)) > To: dev@commons.apache.org > > > Online report : > https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28016&projectId=73 > > Build statistics: > State: Failed > Previous State: Ok > Started at: Wed 5 Feb 2014 10:20:16 +0000 > Finished at: Wed 5 Feb 2014 10:22:12 +0000 > Total time: 1m 56s > Build Trigger: Schedule > Build Number: 196 > Exit code: 1 > Building machine hostname: continuum-vm > Operating system : Linux(unknown) > Java Home version : > java version "1.7.0_25" > OpenJDK Runtime Environment (IcedTea 2.3.10) > (7u25-2.3.10-1ubuntu0.12.04.2) > OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode) > > Builder version : > Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+0000) > Java version: 1.7.0_25 > Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre > Default locale: en_US, platform encoding: ANSI_X3.4-1968 > OS name: "linux" version: "3.2.0-53-generic" arch: "amd64" > Family: "unix" > > **************************************************************************** > SCM Changes: > **************************************************************************** > Changed: markt @ Wed 5 Feb 2014 09:31:07 +0000 > Comment: Fix DBCP-406 > Add support for pooling PreparedStatements that use auto-generated keys. > Patch by Steeve Beroard. > Files changed: > /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564688 ) > > /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java > ( 1564688 ) > > /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java > ( 1564688 ) > > **************************************************************************** > Dependencies Changes: > **************************************************************************** > No dependencies changed > > > **************************************************************************** > Build Definition: > **************************************************************************** > POM filename: pom.xml > Goals: clean deploy > Arguments: --batch-mode -Dgpg.skip -Prelease > Build Fresh: false > Always Build: false > Default Build Definition: true > Schedule: COMMONS_SCHEDULE > Profile Name: Maven 2.2.1 with Java 7 > Description: Project Maven 2 Build Definition (Java 1.7) > > **************************************************************************** > Test Summary: > **************************************************************************** > Tests: 483 > Failures: 0 > Errors: 7 > Success Rate: 98 > Total time: 78.642 > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
