Also done for 1.5 branch However the test TestSharedPoolDataSource.testClosePool() is failing in both Ant and Maven.
I don't think that's related to the source move. On 30 January 2014 21:28, sebb <seb...@gmail.com> wrote: > On 30 January 2014 20:54, Mark Thomas <ma...@apache.org> wrote: >> On 30/01/2014 20:40, sebb wrote: >>> @Mark: I have done a local experiment, and compile/test works fine >>> (not many changes needed to pom or build.xml) >>> >>> However the change will obviously affect concurrent activity. >>> If you are agreeable to the change, please can you let me know when >>> there is a window where you are temporarily done with changes. >> >> I've just checked in the test I was looking at. Luckily it passes when I >> was expecting it to fail so I can carry on investigating that with a >> clean tree while you do your work. > > OK, all done on trunk. > > Local build works OK as does Continuum. > >> Mark >> >>> >>> Thanks! >>> >>> >>> >>> On 30 January 2014 19:57, Benedikt Ritter <brit...@apache.org> wrote: >>>> Go for it! >>>> >>>> >>>> 2014/1/30 sebb <seb...@gmail.com> >>>> >>>>> At present DBCP uses a non-standard Maven layout. >>>>> >>>>> For example src/java should really be src/main/java >>>>> >>>>> Generally the poms are easier to configure if the standard layout [1] is >>>>> used. >>>>> Commons Parent generally assumes the standard layout as does the Apache >>>>> pom. >>>>> >>>>> OK if I fix this? >>>>> [Obviously the Ant build.xml would also need to be updated] >>>>> >>>>> [1] >>>>> http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>>> >>>> >>>> >>>> -- >>>> http://people.apache.org/~britter/ >>>> http://www.systemoutprintln.de/ >>>> http://twitter.com/BenediktRitter >>>> http://github.com/britter >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
